public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Huang, Ying" <ying.huang@intel.com>
To: Ingo Molnar <mingo@elte.hu>, venkatesh.pallipadi@intel.com
Cc: akpm@linux-foundation.org, "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@suse.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 0/3] i386 boot: replace boot_ioremap with enhanced bt_ioremap
Date: Tue, 15 Jan 2008 17:48:55 +0800	[thread overview]
Message-ID: <1200390535.3505.62.camel@caritas-dev.intel.com> (raw)
In-Reply-To: <20080115084417.GA16449@elte.hu>

On Tue, 2008-01-15 at 09:44 +0100, Ingo Molnar wrote:
> * Huang, Ying <ying.huang@intel.com> wrote:
> 
> > This patchset replaces boot_ioremap with a enhanced version of 
> > bt_ioremap and renames the bt_ioremap to early_ioremap. This reduces 
> > 12k from .init.data segment and increases the size of memory that can 
> > be re-mapped before paging_init to 64k.
> 
> in latest x86.git#mm there's an early_ioremap() introduced as part of 
> the PAT series - available on both 32-bit and 64-bit. Could you take a 
> look at it and use that if it's OK for your purposes?

After checking the early_ioremap() implementation in
arch/x86/kernel/setup_32.c, I found that it is a duplication of
bt_ioremap() implementation in arch/x86/mm/ioremap_32.c. Both
implementations use set_fixmap(), so they can be used only after
paging_init().

The early_ioremap implementation provided in this patchset works as
follow:

- Enhances bt_ioremap, make it usable before paging_init() via a
dedicated PTE page.
- Rename bt_ioremap to early_ioremap

So I think maybe we should replace the early_ioremap() implementation in
PAT series with that of this series.

Best Regards,
Huang Ying


  reply	other threads:[~2008-01-15  9:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-15  5:45 [PATCH -mm 0/3] i386 boot: replace boot_ioremap with enhanced bt_ioremap Huang, Ying
2008-01-15  8:44 ` Ingo Molnar
2008-01-15  9:48   ` Huang, Ying [this message]
2008-01-15 12:52     ` H. Peter Anvin
2008-01-15 13:39       ` Ingo Molnar
2008-01-15 13:38         ` H. Peter Anvin
2008-01-15 13:36     ` Ingo Molnar
2008-01-16  2:51     ` [PATCH -mm 0/3] i386 boot: replace boot_ioremap with enhancedbt_ioremap Pallipadi, Venkatesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1200390535.3505.62.camel@caritas-dev.intel.com \
    --to=ying.huang@intel.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox