Re: [PATCH] [12/31] CPA: CLFLUSH support in change_page_attr()

Jan Beulich
2008-01-15T08:40:23Z

>- /* clflush is still broken. Disable for now. */
>- if (1 || !cpu_has_clflush)
>+ if (a->full_flush)
> asm volatile("wbinvd" ::: "memory");
>- else list_for_each_entry(pg, l, lru) {
>- void *adr = page_address(pg);
>- clflush_cache_range(adr, PAGE_SIZE);
>+ list_for_each_entry(f, &a->l, l) {
>+ if (!a->full_flush)

This if() looks redundant (could also be avoided in the 32-bit variant, but
isn't redundant there at present). Also, is there no
wbinvd() on 64bit?

Jan