Re: [PATCH] [13/31] CPA: Use macros to modify the PG_arch_1 page flags in change_page_attr

Harvey Harrison
2008-01-15T10:15:17Z

On Tue, 2008-01-15 at 11:06 +0100, Andi Kleen wrote:
> On Tuesday 15 January 2008 10:29:51 Harvey Harrison wrote:
> > On Mon, 2008-01-14 at 23:16 +0100, Andi Kleen wrote:
> > > Instead of open coding the bit accesses uses standard style
> > > *PageDeferred* macros.
> > >
> >
> > Any reason these couldn't be static inlines in a shared header?
>
> The whole usage of that bit is private to the file

True if pageattr_32|64.c get merged, not one I have looked at yet,
but wouldn't a static inline in the files then be better for the
typechecking?

Harvey