From: Harvey Harrison <harvey.harrison@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] x86: unify pt_regs accessors ptrace.h
Date: Thu, 17 Jan 2008 18:08:09 -0800 [thread overview]
Message-ID: <1200622089.5724.102.camel@brick> (raw)
In-Reply-To: <4790074F.2020000@zytor.com>
On Thu, 2008-01-17 at 20:56 -0500, H. Peter Anvin wrote:
> Harvey Harrison wrote:
> > Unify the definiton of:
> > v8086_mode
> > user_mode
> > user_mode_vm
> > stack_pointer
> > instruction_pointer
> > frame_pointer
> >
> > in ptrace.h to make it clear where the differences are between
> > 32 and 64 bit. Changes macros to static inlines as well.
> >
>
> Can you put a comment on stack_pointer() that it applies to a
> kernel-mode pt_regs only?
How about a follow-on patch that picks a better name and adds the
comment? I'd like to leave this as a movement-only patch. Once we
decide on a name I'll do the rename/comment. It seems like there are
very few users currently (oprofile/backtrace.c only?).
Then I'll also change the kprobes code to use this instead of their
stack_addr helper.
Harvey
next prev parent reply other threads:[~2008-01-18 2:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-18 1:59 [PATCH 1/2] x86: unify pt_regs accessors ptrace.h Harvey Harrison
2008-01-18 1:56 ` H. Peter Anvin
2008-01-18 2:08 ` Harvey Harrison [this message]
2008-01-18 2:05 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200622089.5724.102.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox