From: Harvey Harrison <harvey.harrison@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>, Andi Kleen <ak@suse.de>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH] x86: Unify printk strings in fault_32|64.c
Date: Fri, 18 Jan 2008 20:22:29 -0800 [thread overview]
Message-ID: <1200716549.5724.150.camel@brick> (raw)
Adding the address of the faulting library missed removing a
line ending from X86_32.
Also update the shorter printk format for X86_32 in fault_64.c
to make it easier to se the remaining differences.
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
Ingo, trivial printk update after Andi's patches.
arch/x86/mm/fault_32.c | 2 +-
arch/x86/mm/fault_64.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/mm/fault_32.c b/arch/x86/mm/fault_32.c
index 793e830..0bd2417 100644
--- a/arch/x86/mm/fault_32.c
+++ b/arch/x86/mm/fault_32.c
@@ -589,7 +589,7 @@ bad_area_nosemaphore:
printk_ratelimit()) {
printk(
#ifdef CONFIG_X86_32
- "%s%s[%d]: segfault at %lx ip %08lx sp %08lx error %lx\n",
+ "%s%s[%d]: segfault at %lx ip %08lx sp %08lx error %lx",
#else
"%s%s[%d]: segfault at %lx ip %lx sp %lx error %lx",
#endif
diff --git a/arch/x86/mm/fault_64.c b/arch/x86/mm/fault_64.c
index 9270a7d..9ac449e 100644
--- a/arch/x86/mm/fault_64.c
+++ b/arch/x86/mm/fault_64.c
@@ -591,7 +591,7 @@ bad_area_nosemaphore:
printk_ratelimit()) {
printk(
#ifdef CONFIG_X86_32
- "%s%s[%d]: segfault at %08lx ip %08lx sp %08lx error %lx\n",
+ "%s%s[%d]: segfault at %lx ip %08lx sp %08lx error %lx",
#else
"%s%s[%d]: segfault at %lx ip %lx sp %lx error %lx",
#endif
--
1.5.4.rc3.1118.gf6754c
next reply other threads:[~2008-01-19 4:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-19 4:22 Harvey Harrison [this message]
2008-01-19 5:08 ` [PATCH] x86: Unify printk strings in fault_32|64.c Andi Kleen
2008-01-19 5:12 ` Harvey Harrison
2008-01-19 8:13 ` Ingo Molnar
2008-01-19 9:04 ` Harvey Harrison
2008-01-19 10:17 ` [RFC PATCH] x86: Pull out oops printing helper from do_page_fault Harvey Harrison
2008-01-19 10:26 ` [RFC PATCHv2] " Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200716549.5724.150.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=ak@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox