From: Marcel Holtmann <marcel@holtmann.org>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bluez-devel@lists.sourceforge.net, cornelia.huck@de.ibm.com,
gombasg@sztaki.hu, htejun@gmail.com, viro@zeniv.linux.org.uk,
kay.sievers@vrfy.org, greg@kroah.com
Subject: Re: [PATCH] bluetooth : move children of connection device to NULL before connection down
Date: Tue, 22 Jan 2008 12:39:20 +0100 [thread overview]
Message-ID: <1201001960.7978.158.camel@aeonflux> (raw)
In-Reply-To: <a8e1da0801220024u30e9c814va74e44252fc8b11e@mail.gmail.com>
Hi Dave,
> could you tell something more about your coding style?
> I would like to submit patches about bluetooth according to your sytle
> later If I have.
>
> Maybe you could put it on the bluez web site or anywhere.
it follows closely the kernel coding style as layout within the kernel
documentation. However there are some minor style things, that I am
going to enforce from time to time. Like having the container_of or
get_user_data calls at the top of the variable declaration. This has
never formalized as far as I recall, but makes from my point of view the
code clearer and easier to read.
Some other times I like an extra empty line to more visual separate
different code blocks. For this some people might agree with me others
might disagree. It is fully a personal more liking one way over the
other.
When it comes to indentation and placement of braces etc. I is 100% the
kernel coding style and nothing else. If not, then it needs fixing and
is an oversight from the old days.
Regards
Marcel
next prev parent reply other threads:[~2008-01-22 11:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-21 4:49 [PATCH] bluetooth : move children of connection device to NULL before connection down Dave Young
2008-01-21 4:54 ` Dave Young
2008-01-21 11:14 ` David Miller
2008-01-22 6:18 ` Marcel Holtmann
2008-01-22 6:26 ` David Miller
2008-01-22 8:24 ` Dave Young
2008-01-22 11:39 ` Marcel Holtmann [this message]
2008-01-23 22:06 ` Andrew Morton
2008-01-24 1:19 ` Dave Young
2008-01-24 1:26 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201001960.7978.158.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=bluez-devel@lists.sourceforge.net \
--cc=cornelia.huck@de.ibm.com \
--cc=davem@davemloft.net \
--cc=gombasg@sztaki.hu \
--cc=greg@kroah.com \
--cc=hidave.darkstar@gmail.com \
--cc=htejun@gmail.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox