Re: [PATCH 21/32] ide-tape: idetape_chrdev_direction_t:shorten enum names

Bartlomiej Zolnierkiewicz
2008-01-27T19:37:13Z

On Sunday 27 January 2008, Borislav Petkov wrote:
> From: Borislav Petkov <bbpetkov@yahoo.de>
>
> Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
> ---
> drivers/ide/ide-tape.c | 60 ++++++++++++++++++++++++-----------------------
> 1 files changed, 31 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
> index cf308d7..b487d56 100644
> --- a/drivers/ide/ide-tape.c
> +++ b/drivers/ide/ide-tape.c
> @@ -178,11 +178,13 @@ enum {
> /*
> * For general magnetic tape device compatibility.
> */
> +
> +/* tape directions */
> typedef enum {
> - idetape_direction_none,
> - idetape_direction_read,
> - idetape_direction_write
> -} idetape_chrdev_direction_t;
> + idetape_dir_none,
> + idetape_dir_read,
> + idetape_dir_write

Could you convert them to upper-case while at it?

> +} idetape_chrdev_dir_t;