From: Joe Perches <joe@perches.com>
To: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/7] X86: include missing KERN_ facility level
Date: Mon, 28 Jan 2008 15:30:35 -0800 [thread overview]
Message-ID: <1201563036.23527.22.camel@localhost> (raw)
In-Reply-To: <20080129000803.69b54c7e@paolo-desktop>
On Tue, 2008-01-29 at 00:08 +0100, Paolo Ciarrocchi wrote:
> \diff --git a/arch/x86/math-emu/errors.c b/arch/x86/math-emu/errors.c
> index 6102fe0..569a62e 100644
> --- a/arch/x86/math-emu/errors.c
> +++ b/arch/x86/math-emu/errors.c
> @@ -57,65 +57,65 @@ void FPU_printall(void)
>
> RE_ENTRANT_CHECK_OFF;
> /* No need to check access_ok(), we have previously fetched these bytes. */
> - printk("At %p:", (void *) address);
> + printk(KERN_ERR "At %p:", (void *) address);
> if (FPU_CS == __USER_CS) {
> #define MAX_PRINTED_BYTES 20
> for (i = 0; i < MAX_PRINTED_BYTES; i++) {
> FPU_get_user(byte1, (u_char __user *) address);
> if ((byte1 & 0xf8) == 0xd8) {
> - printk(" %02x", byte1);
> + printk(KERN_ERR " %02x", byte1);
> break;
> }
> - printk(" [%02x]", byte1);
> + printk(KERN_ERR " [%02x]", byte1);
> address++;
> }
KERN_ prefixes are used only at the start of a line.
You should probably use print_hex_dump.
next prev parent reply other threads:[~2008-01-28 23:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-28 23:08 [PATCH 6/7] X86: include missing KERN_ facility level Paolo Ciarrocchi
2008-01-28 23:30 ` Joe Perches [this message]
2008-01-31 22:57 ` Paolo Ciarrocchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201563036.23527.22.camel@localhost \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paolo.ciarrocchi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox