public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: Jon Masters <jonathan@jonmasters.org>
Cc: Jan Engelhardt <jengelh@computergmbh.de>,
	linux-kernel@vger.kernel.org,
	Rusty Russell <rusty@rustcorp.com.au>,
	Giridhar Pemmasani <pgiri@yahoo.com>
Subject: Re: ndiswrapper and GPL-only symbols redux
Date: Tue, 29 Jan 2008 20:33:50 -0500	[thread overview]
Message-ID: <1201656830.24898.6.camel@dv> (raw)
In-Reply-To: <1201654094.2271.105.camel@perihelion>

On Tue, 2008-01-29 at 19:48 -0500, Jon Masters wrote:
> On Wed, 2008-01-30 at 01:35 +0100, Jan Engelhardt wrote:
> > On Jan 29 2008 19:20, Jon Masters wrote:
> 
> > >Another fix would be for ndiswrapper to explicitly set the taint when it
> > >loads a tainted driver? Or do we just want to go back to globally
> > >"tainting" the kernel without assigning the blame to any module?
> > 
> > I think the global taint flag is always needed because you never know
> > what the proprietary module actually did to our memory. Unloading
> > the driver and ndiswrapper should retain some sort of taintedness
> > should it oops much later.
> 
> It will. The module taint variant also sets the global taint. But it
> helps to know why you set that if you oops now and get a list of
> modules. Yeah, we know about ndiswrapper, I just mean in general.

Then we can move add_taint_module() for ndiswrapper closer to the end of
load_module(), so that it's not prevented from using GPL-only symbols.

driverloader should stay where it is, since we don't trust its license.

> Man, that'll teach me to send one-liners without checking the entire
> history of LWN stories beforehand. I'm going to the gym to escape :)

I'm actually so relieved that it has been mistake, just like it was the
last time.  Good luck!

-- 
Regards,
Pavel Roskin

  reply	other threads:[~2008-01-30  1:34 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-29 21:22 ndiswrapper and GPL-only symbols redux Pavel Roskin
2008-01-29 22:27 ` Valdis.Kletnieks
2008-01-29 22:35   ` Giridhar Pemmasani
2008-01-29 23:21   ` Pavel Roskin
2008-01-30  0:25     ` Jon Masters
2008-01-29 22:45 ` Alan Cox
2008-01-29 23:56   ` Pavel Roskin
2008-01-30  3:24     ` Andi Kleen
2008-01-30  5:07       ` Jon Masters
2008-01-30  5:26         ` Pavel Roskin
2008-01-30  6:03           ` Andi Kleen
2008-01-30  6:12             ` Pavel Roskin
2008-01-29 22:57 ` Adrian Bunk
2008-01-29 23:04   ` Alan Cox
2008-01-29 23:06   ` Jan Engelhardt
2008-01-29 23:25   ` Måns Rullgård
2008-01-30  0:35     ` Adrian Bunk
2008-01-30  0:46       ` Måns Rullgård
2008-01-30  1:44         ` Daniel Hazelton
2008-01-30  7:38         ` Geert Uytterhoeven
2008-01-30  8:45           ` Måns Rullgård
2008-01-30 21:00           ` David Schwartz
2008-01-29 23:44   ` Pavel Roskin
2008-01-30  0:25     ` Adrian Bunk
2008-01-30  2:02       ` Pavel Roskin
2008-01-30 11:24         ` Rusty Russell
2008-01-30 17:54         ` Adrian Bunk
2008-01-30 18:15           ` Lennart Sorensen
2008-01-30 18:45             ` Adrian Bunk
2008-01-30 19:43               ` Lennart Sorensen
2008-01-30 20:26                 ` Valdis.Kletnieks
2008-01-30 21:09                   ` Adrian Bunk
     [not found]     ` <E1JKJvh-0006P8-Pi@fencepost.gnu.org>
2008-02-01  5:08       ` Pavel Roskin
2008-02-06 10:50         ` Adrian Bunk
2008-02-06 11:11           ` Xavier Bestel
2008-02-06 11:38           ` David Schwartz
2008-02-06 15:10             ` Theodore Tso
2008-01-30  0:48   ` Giridhar Pemmasani
2008-01-30 17:54     ` Adrian Bunk
2008-01-30 18:26       ` Chris Friesen
2008-01-30 18:54         ` Adrian Bunk
2008-01-30 19:36           ` Lee Revell
2008-01-30 20:28             ` Adrian Bunk
2008-01-31  1:00               ` Michael Gerdau
2008-02-05 13:00                 ` Adrian Bunk
2008-02-04 12:42             ` Alan Cox
2008-02-04 13:56               ` Adrian Bunk
2008-01-31  3:25       ` David Newall
2008-01-31 15:20         ` Chris Friesen
2008-01-30  0:20 ` Jon Masters
2008-01-30  0:35   ` Jan Engelhardt
2008-01-30  0:48     ` Jon Masters
2008-01-30  1:33       ` Pavel Roskin [this message]
2008-01-30  1:48   ` Pavel Roskin
2008-01-30  2:08     ` Jan Engelhardt
2008-01-30  5:04     ` Jon Masters
2008-01-30  5:38       ` Zan Lynx
2008-01-30  7:40         ` Geert Uytterhoeven
2008-01-30  8:54           ` Måns Rullgård
2008-01-30 20:50       ` David Schwartz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1201656830.24898.6.camel@dv \
    --to=proski@gnu.org \
    --cc=jengelh@computergmbh.de \
    --cc=jonathan@jonmasters.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pgiri@yahoo.com \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox