Re: [PATCH v1 1/3] ARM64 LPC: indirect ISA PORT IO introduced

Will Deacon
2016-01-04T10:11:34Z

On Wed, Dec 30, 2015 at 10:42:50AM +0100, Arnd Bergmann wrote:
> On Wednesday 30 December 2015 17:28:20 Rongrong Zou wrote:
> > >>
> > >
> > > config ARM64_INDIRECT_PIO
> > > bool
> > > help
> > > Any driver that provides indirect ISA I/O port access should select
> > > this symbol
> >
> >
> > >
> > > config HISILICON_HI123456_LPC
> > > bool "Workaround for nonstandard ISA I/O space on Hisilicon Hi123456 SoC"
> > > depends on ARCH_HISI || COMPILE_TEST
> > > select ARM64_INDIRECT_PIO
> > > help
> > > ...
> > Can it be a submenu of "Platform selection--->Hisilicon SoC Family"?
>
> The first should be in the main Kconfig file for arm64, the second one depends
> on where we put the respective code. I'd say both the Kconfig entry and the file
> can go into drivers/bus, but arch/arm64/kernel/ is also fine with me.

Unsurprisingly, I'd *much* prefer drivers/bus/ !

Will