Re: [PATCH v1 1/3] ARM64 LPC: indirect ISA PORT IO introduced

Arnd Bergmann
2015-12-30T08:59:40Z

On Wednesday 30 December 2015 09:24:04 Rongrong Zou wrote:
> >>>> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> >>>> index 4043c35..98ae206 100644
> >>>> --- a/arch/arm64/Kconfig.platforms
> >>>> +++ b/arch/arm64/Kconfig.platforms
> >>>> @@ -127,5 +127,8 @@ config ARCH_ZYNQMP
> >>>> bool "Xilinx ZynqMP Family"
> >>>> help
> >>>> This enables support for Xilinx ZynqMP Family
> >>>> -
> >>>> +config ARM64_INDIRECT_PIO
> >>>> + bool "ARM64 Indirect port I/O"
> >>>> + help
> >>>> + This enables support for ARM64 indirect port I/O
> >>>> endmenu
> >>>
> >>> The option should probably go into arch/arm64/Kconfig. Possibly you can make
> >>> it a silent option that just gets selected whenever a driver is enabled
> >>> that might set the callbacks.
> >>
> >> I try to bind it with HISILICON platform.
> >
> > It should be possible to build the actual driver on all platforms, at
> > least with COMPILE_TEST.
>
> Sorry, I'm a little confused, can you describe it in detail?
>
>

config ARM64_INDIRECT_PIO
bool
help
Any driver that provides indirect ISA I/O port access should select
this symbol

config HISILICON_HI123456_LPC
bool "Workaround for nonstandard ISA I/O space on Hisilicon Hi123456 SoC"
depends on ARCH_HISI || COMPILE_TEST
select ARM64_INDIRECT_PIO
help
...

Arnd