* [PATCH] x86: fix sparse warning in kernel/scx200_32.c
@ 2008-01-31 3:57 Harvey Harrison
2008-01-31 14:58 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2008-01-31 3:57 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Thomas Gleixner, LKML, H. Peter Anvin
arch/x86/kernel/scx200_32.c:68:72: warning: Using plain integer as NULL pointer
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
arch/x86/kernel/scx200_32.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/scx200_32.c b/arch/x86/kernel/scx200_32.c
index 87bc159..7e004ac 100644
--- a/arch/x86/kernel/scx200_32.c
+++ b/arch/x86/kernel/scx200_32.c
@@ -65,7 +65,7 @@ static int __devinit scx200_probe(struct pci_dev *pdev, const struct pci_device_
base = pci_resource_start(pdev, 0);
printk(KERN_INFO NAME ": GPIO base 0x%x\n", base);
- if (request_region(base, SCx200_GPIO_SIZE, "NatSemi SCx200 GPIO") == 0) {
+ if (!request_region(base, SCx200_GPIO_SIZE, "NatSemi SCx200 GPIO")) {
printk(KERN_ERR NAME ": can't allocate I/O for GPIOs\n");
return -EBUSY;
}
--
1.5.4.rc4.1142.gf5a97
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: fix sparse warning in kernel/scx200_32.c
2008-01-31 3:57 [PATCH] x86: fix sparse warning in kernel/scx200_32.c Harvey Harrison
@ 2008-01-31 14:58 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-01-31 14:58 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Thomas Gleixner, LKML, H. Peter Anvin
* Harvey Harrison <harvey.harrison@gmail.com> wrote:
> arch/x86/kernel/scx200_32.c:68:72: warning: Using plain integer as
> NULL pointer
thanks, applied.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-01-31 14:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-31 3:57 [PATCH] x86: fix sparse warning in kernel/scx200_32.c Harvey Harrison
2008-01-31 14:58 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox