From: John Stultz <johnstul@us.ibm.com>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Christoph Hellwig <hch@infradead.org>,
Gregory Haskins <ghaskins@novell.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Thomas Gleixner <tglx@linutronix.de>,
Tim Bird <tim.bird@am.sony.com>, Sam Ravnborg <sam@ravnborg.org>,
"Frank Ch. Eigler" <fche@redhat.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Arjan van de Ven <arjan@infradead.org>,
Steven Rostedt <srostedt@redhat.com>
Subject: Re: [PATCH 06/23 -v8] handle accurate time keeping over long delays
Date: Thu, 31 Jan 2008 09:24:57 -0800 [thread overview]
Message-ID: <1201800297.6789.14.camel@jstultz-laptop> (raw)
In-Reply-To: <20080131121037.GB8493@Krystal>
On Thu, 2008-01-31 at 07:10 -0500, Mathieu Desnoyers wrote:
> * Steven Rostedt (rostedt@goodmis.org) wrote:
> > From: John Stultz <johnstul@us.ibm.com>
> >
> > Handle accurate time even if there's a long delay between
> > accumulated clock cycles.
> >
>
> About this one.. we talked a lot about the importance of timekeeping at
> the first Montreal Tracing Summit this week. Actually, someone
> mentioned a very interesting point : in order to be able to synchronize
> traces taken from the machine with traces taken on external hardware
> (i.e. memory bus tracer on Freescale), taking the "real" counter value
> rather that using the "cumulated cycles" approach (which creates a
> virtual counted instead) would be better.
>
> So I would recommend using an algorithm that would return a clock value
> which is the same as the underlying hardware counter.
Hmm. It is an interesting issue. Clearly having the raw cycle value
match up so hardware analysis could be mapped to software timestamps
would be useful(although obscure) feature. However with the variety of
clocksources, dealing properly with the clocksource wrap issue (ACPI PM
for instance wraps about every 5 seconds) also has to be addressed.
I think you were mentioning an idea that required some work on the read
side to handle the wraps, basically managing the high order bits by
hand. This sounds like it would be an additional feature that could be
added on to the infrastructure being provided in the
get_monotonic_cycles() patch. No?
However, all of the above is a separate issue then what this (the
timekeeping over long delay) patch addresses, as it is not really
directly related to the get_monotonic_cycles() patch, but instead allows
for correct timekeeping, making update_wall_time() to function properly
if it was deferred for longer then the clocksource's wrap time.
thanks
-john
next prev parent reply other threads:[~2008-01-31 17:25 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 21:03 [PATCH 00/23 -v8] mcount and latency tracing utility -v8 Steven Rostedt
2008-01-30 21:03 ` [PATCH 01/23 -v8] printk - dont wakeup klogd with interrupts disabled Steven Rostedt
2008-01-30 21:03 ` [PATCH 02/23 -v8] Add basic support for gcc profiler instrumentation Steven Rostedt
2008-01-30 21:04 ` [PATCH 03/23 -v8] Annotate core code that should not be traced Steven Rostedt
2008-01-30 21:04 ` [PATCH 04/23 -v8] x86_64: notrace annotations Steven Rostedt
2008-01-30 21:04 ` [PATCH 05/23 -v8] add notrace annotations to vsyscall Steven Rostedt
2008-01-30 21:04 ` [PATCH 06/23 -v8] handle accurate time keeping over long delays Steven Rostedt
2008-01-31 12:10 ` Mathieu Desnoyers
2008-01-31 17:24 ` John Stultz [this message]
2008-02-01 17:02 ` Mathieu Desnoyers
2008-02-02 7:11 ` Steven Rostedt
2008-02-02 16:30 ` Mathieu Desnoyers
2008-01-30 21:04 ` [PATCH 07/23 -v8] initialize the clock source to jiffies clock Steven Rostedt
2008-01-30 21:04 ` [PATCH 08/23 -v8] add get_monotonic_cycles Steven Rostedt
2008-01-30 21:04 ` [PATCH 09/23 -v8] add notrace annotations to timing events Steven Rostedt
2008-01-30 21:04 ` [PATCH 10/23 -v8] mcount tracer add preempt_enable/disable notrace macros Steven Rostedt
2008-01-30 21:04 ` [PATCH 11/23 -v8] mcount based trace in the form of a header file library Steven Rostedt
2008-01-30 21:04 ` [PATCH 12/23 -v8] Add context switch marker to sched.c Steven Rostedt
2008-01-30 21:04 ` [PATCH 13/23 -v8] Make the task State char-string visible to all Steven Rostedt
2008-01-30 21:04 ` [PATCH 14/23 -v8] Add tracing of context switches Steven Rostedt
2008-02-05 17:04 ` Tim Bird
2008-01-30 21:04 ` [PATCH 15/23 -v8] Generic command line storage Steven Rostedt
2008-01-30 21:04 ` [PATCH 16/23 -v8] trace generic call to schedule switch Steven Rostedt
2008-01-30 21:04 ` [PATCH 17/23 -v8] Add marker in try_to_wake_up Steven Rostedt
2008-01-30 21:04 ` [PATCH 18/23 -v8] mcount tracer for wakeup latency timings Steven Rostedt
2008-01-30 21:04 ` [PATCH 19/23 -v8] Trace irq disabled critical timings Steven Rostedt
2008-01-30 21:04 ` [PATCH 20/23 -v8] trace preempt off " Steven Rostedt
2008-01-30 21:04 ` [PATCH 21/23 -v8] Add markers to various events Steven Rostedt
2008-01-31 12:06 ` Mathieu Desnoyers
2008-02-02 7:00 ` Steven Rostedt
2008-02-02 14:14 ` Mathieu Desnoyers
2008-01-30 21:04 ` [PATCH 22/23 -v8] Add event tracer Steven Rostedt
2008-01-30 21:04 ` [PATCH 23/23 -v8] Critical latency timings histogram Steven Rostedt
2008-02-05 17:11 ` [PATCH 00/23 -v8] mcount and latency tracing utility -v8 Tim Bird
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201800297.6789.14.camel@jstultz-laptop \
--to=johnstul@us.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=fche@redhat.com \
--cc=ghaskins@novell.com \
--cc=hch@infradead.org \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=sam@ravnborg.org \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
--cc=tim.bird@am.sony.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox