* [PATCH] x86: make early_console static in early_printk.c
@ 2008-02-01 8:40 Harvey Harrison
2008-02-01 10:47 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2008-02-01 8:40 UTC (permalink / raw)
To: Ingo Molnar; +Cc: H. Peter Anvin, Thomas Gleixner, LKML
Not necessary to expose it, also fixes sparse warning.
arch/x86/kernel/early_printk.c:196:16: warning: symbol 'early_console' was not declared. Should it be static?
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
arch/x86/kernel/early_printk.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/early_printk.c b/arch/x86/kernel/early_printk.c
index b7d6c23..cff84cd 100644
--- a/arch/x86/kernel/early_printk.c
+++ b/arch/x86/kernel/early_printk.c
@@ -193,7 +193,7 @@ static struct console simnow_console = {
};
/* Direct interface for emergencies */
-struct console *early_console = &early_vga_console;
+static struct console *early_console = &early_vga_console;
static int early_console_initialized = 0;
void early_printk(const char *fmt, ...)
--
1.5.4.rc4.1142.gf5a97
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: make early_console static in early_printk.c
2008-02-01 8:40 [PATCH] x86: make early_console static in early_printk.c Harvey Harrison
@ 2008-02-01 10:47 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-02-01 10:47 UTC (permalink / raw)
To: Harvey Harrison; +Cc: H. Peter Anvin, Thomas Gleixner, LKML
* Harvey Harrison <harvey.harrison@gmail.com> wrote:
> /* Direct interface for emergencies */
> -struct console *early_console = &early_vga_console;
> +static struct console *early_console = &early_vga_console;
thanks, applied.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-01 10:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-01 8:40 [PATCH] x86: make early_console static in early_printk.c Harvey Harrison
2008-02-01 10:47 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox