From: Ian Campbell <ijc@hellion.org.uk>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: David Newall <davidn@davidnewall.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH] x86: add a crc32 checksum to the kernel image.
Date: Fri, 01 Feb 2008 10:58:14 +0000 [thread overview]
Message-ID: <1201863494.25409.76.camel@localhost.localdomain> (raw)
In-Reply-To: <47A272D8.7030106@zytor.com>
On Thu, 2008-01-31 at 17:16 -0800, H. Peter Anvin wrote:
> David Newall wrote:
> > Isn't a crc32 calculation already defined? Yes; in lib/crc32.c. One is
> > surely enough.
>
> As long as it can be included in user-space code we should use that one.
I don't think it can. There is a main function surrounded by #ifdef
UNITTEST which might once have worked but now there is far too much
kernel gunk in there (as you might expect).
If I can work up the enthusiasm I might break out the core algorithm
into a separate file that can be used in both the kernel and userspace.
Ian.
--
Ian Campbell
Current Noise: Reverend Bizarre - Cirith Ungol
"Would I turn on the gas if my pal Mugsy were in there?"
"You might, rabbit, you might!"
-- Looney Tunes, Bugs and Thugs (1954, Friz Freleng)
next prev parent reply other threads:[~2008-02-01 10:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 21:45 [PATCH] x86: define OBJCOPYFLAGS explicitly for each target Ian Campbell
2008-01-31 21:45 ` [PATCH] x86: use ELF format in compressed images Ian Campbell
2008-01-31 21:45 ` [PATCH] x86: add a crc32 checksum to the kernel image Ian Campbell
2008-01-31 21:45 ` [PATCH] x86: bump image header to version 2.08 Ian Campbell
2008-01-31 22:10 ` [PATCH] x86: add a crc32 checksum to the kernel image H. Peter Anvin
2008-02-01 0:23 ` H. Peter Anvin
2008-02-01 9:02 ` Ian Campbell
2008-02-01 13:07 ` Ingo Molnar
2008-02-06 1:09 ` Randy Dunlap
2008-02-06 20:58 ` Ian Campbell
2008-02-06 21:01 ` Randy Dunlap
2008-02-01 0:43 ` David Newall
2008-02-01 1:16 ` H. Peter Anvin
2008-02-01 5:46 ` David Newall
2008-02-01 10:58 ` Ian Campbell [this message]
2008-01-31 22:45 ` [PATCH] x86: define OBJCOPYFLAGS explicitly for each target Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201863494.25409.76.camel@localhost.localdomain \
--to=ijc@hellion.org.uk \
--cc=davidn@davidnewall.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox