Build error on PowerPC

Build error on PowerPC

[Marcel Holtmann]

Hi,

I get the following build error on PowerPC:

  CC [M]  sound/ppc/awacs.o
In file included from sound/ppc/awacs.c:25:
include/asm/nvram.h:62: error: field ‘partition’ has incomplete type
make[2]: *** [sound/ppc/awacs.o] Error 1
make[1]: *** [sound/ppc] Error 2
make: *** [sound] Error 2

Regards

Marcel

Re: Build error on PowerPC

[Olof Johansson]

Hi,

Please define what kernel version and what config you're trying to
build.

Also, please cc linuxppc-dev@ozlabs.org for powerpc issues.


Thanks,

Olof

On Fri, Feb 01, 2008 at 12:44:39PM +0100, Marcel Holtmann wrote:
> Hi,
> 
> I get the following build error on PowerPC:
> 
>   CC [M]  sound/ppc/awacs.o
> In file included from sound/ppc/awacs.c:25:
> include/asm/nvram.h:62: error: field ???partition??? has incomplete type
> make[2]: *** [sound/ppc/awacs.o] Error 1
> make[1]: *** [sound/ppc] Error 2
> make: *** [sound] Error 2
> 
> Regards
> 
> Marcel
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Re: Build error on PowerPC

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

Hi Olof,

> Please define what kernel version and what config you're trying to
> build.

it is the latest kernel for Linus' git and the config is kinda obviously
enabling the awacs.c driver. Anyway, the driver didn't make use of the
NVRAM call and thus removing that include is perfectly fine. Attached
patch fixes that issue.

> Also, please cc linuxppc-dev@ozlabs.org for powerpc issues.

To be quite honest, it is highly likely that I forget the next time.
Good that you read LKML :)

Regards

Marcel


[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 1109 bytes --]

[PATCH] Fix compilation of sound/ppc/awacs.c

Including of asm/nvram.h in the awacs.c driver is not needed and it
fixes the following compilation error:

  CC [M]  sound/ppc/awacs.o
In file included from sound/ppc/awacs.c:25:
include/asm/nvram.h:62: error: field ‘partition’ has incomplete type
make[2]: *** [sound/ppc/awacs.o] Error 1
make[1]: *** [sound/ppc] Error 2
make: *** [sound] Error 2

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

---
commit 5613f9f9aa321cf59915137cc611aea9fd95ed75
tree 3c55137ccc3d16e49b757a0e6135f32fb2086ae3
parent aa6299926950c8dfe2fea638276cad6def092bc9
author Marcel Holtmann <marcel@holtmann.org> Sat, 02 Feb 2008 03:52:23 +0100
committer Marcel Holtmann <marcel@holtmann.org> Sat, 02 Feb 2008 03:52:23 +0100

 sound/ppc/awacs.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/sound/ppc/awacs.c b/sound/ppc/awacs.c
index 8441e78..149c4aa 100644
--- a/sound/ppc/awacs.c
+++ b/sound/ppc/awacs.c
@@ -21,7 +21,6 @@
 
 
 #include <asm/io.h>
-#include <asm/nvram.h>
 #include <linux/init.h>
 #include <linux/delay.h>
 #include <linux/slab.h>

Re: Build error on PowerPC

[Olof Johansson]

On Sat, Feb 02, 2008 at 03:57:07AM +0100, Marcel Holtmann wrote:
> Hi Olof,
> 
> > Please define what kernel version and what config you're trying to
> > build.
> 
> it is the latest kernel for Linus' git and the config is kinda obviously
> enabling the awacs.c driver. Anyway, the driver didn't make use of the
> NVRAM call and thus removing that include is perfectly fine. Attached
> patch fixes that issue.

Sure, but it could have been dependent on other options around it (i.e.
nvram-related ones). It's just good habit to include the info, that's
all.

> > Also, please cc linuxppc-dev@ozlabs.org for powerpc issues.
> 
> To be quite honest, it is highly likely that I forget the next time.
> Good that you read LKML :)

Well, sometimes I do, sometimes others do. It just might take longer for
someone to stuble over it. :-)


-Olof