* [PATCH 2/3] x86: add function prototype to vm86.h
@ 2008-02-02 7:48 Harvey Harrison
2008-02-02 8:14 ` Li Zefan
2008-02-02 9:04 ` Ingo Molnar
0 siblings, 2 replies; 4+ messages in thread
From: Harvey Harrison @ 2008-02-02 7:48 UTC (permalink / raw)
To: Ingo Molnar; +Cc: H. Peter Anvin, Thomas Gleixner, LKML
Global functions should include their prototypes.
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
include/asm-x86/vm86.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/asm-x86/vm86.h b/include/asm-x86/vm86.h
index a5edf51..b72b9a6 100644
--- a/include/asm-x86/vm86.h
+++ b/include/asm-x86/vm86.h
@@ -195,6 +195,7 @@ struct kernel_vm86_struct {
void handle_vm86_fault(struct kernel_vm86_regs *, long);
int handle_vm86_trap(struct kernel_vm86_regs *, long, int);
+struct pt_regs * save_v86_state(struct kernel_vm86_regs *);
struct task_struct;
void release_vm86_irqs(struct task_struct *);
--
1.5.4.rc4.1142.gf5a97
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/3] x86: add function prototype to vm86.h
2008-02-02 7:48 [PATCH 2/3] x86: add function prototype to vm86.h Harvey Harrison
@ 2008-02-02 8:14 ` Li Zefan
2008-02-02 8:27 ` Harvey Harrison
2008-02-02 9:04 ` Ingo Molnar
1 sibling, 1 reply; 4+ messages in thread
From: Li Zefan @ 2008-02-02 8:14 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Ingo Molnar, H. Peter Anvin, Thomas Gleixner, LKML
Harvey Harrison 写道:
> Global functions should include their prototypes.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> include/asm-x86/vm86.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/asm-x86/vm86.h b/include/asm-x86/vm86.h
> index a5edf51..b72b9a6 100644
> --- a/include/asm-x86/vm86.h
> +++ b/include/asm-x86/vm86.h
> @@ -195,6 +195,7 @@ struct kernel_vm86_struct {
>
> void handle_vm86_fault(struct kernel_vm86_regs *, long);
> int handle_vm86_trap(struct kernel_vm86_regs *, long, int);
> +struct pt_regs * save_v86_state(struct kernel_vm86_regs *);
>
This fixes a sparse warning, but contribute to a coding style error.
checkpatch.pl complains about this patch.
so the above line should be:
struct pt_regs *save_v86_state(struct kernel_vm86_regs *);
> struct task_struct;
> void release_vm86_irqs(struct task_struct *);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 2/3] x86: add function prototype to vm86.h
2008-02-02 8:14 ` Li Zefan
@ 2008-02-02 8:27 ` Harvey Harrison
0 siblings, 0 replies; 4+ messages in thread
From: Harvey Harrison @ 2008-02-02 8:27 UTC (permalink / raw)
To: Li Zefan; +Cc: Ingo Molnar, H. Peter Anvin, Thomas Gleixner, LKML
On Sat, 2008-02-02 at 16:14 +0800, Li Zefan wrote:
> Harvey Harrison 写道:
> > Global functions should include their prototypes.
> >
> > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> > ---
> > include/asm-x86/vm86.h | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/asm-x86/vm86.h b/include/asm-x86/vm86.h
> > index a5edf51..b72b9a6 100644
> > --- a/include/asm-x86/vm86.h
> > +++ b/include/asm-x86/vm86.h
> > @@ -195,6 +195,7 @@ struct kernel_vm86_struct {
> >
> > void handle_vm86_fault(struct kernel_vm86_regs *, long);
> > int handle_vm86_trap(struct kernel_vm86_regs *, long, int);
> > +struct pt_regs * save_v86_state(struct kernel_vm86_regs *);
> >
>
> This fixes a sparse warning, but contribute to a coding style error.
> checkpatch.pl complains about this patch.
Bugger, thought I caught that. Hopefully Ingo will delete the extra
space when applying, otherwise I'll send a replacement.
My apologies,
Harvey
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/3] x86: add function prototype to vm86.h
2008-02-02 7:48 [PATCH 2/3] x86: add function prototype to vm86.h Harvey Harrison
2008-02-02 8:14 ` Li Zefan
@ 2008-02-02 9:04 ` Ingo Molnar
1 sibling, 0 replies; 4+ messages in thread
From: Ingo Molnar @ 2008-02-02 9:04 UTC (permalink / raw)
To: Harvey Harrison; +Cc: H. Peter Anvin, Thomas Gleixner, LKML
* Harvey Harrison <harvey.harrison@gmail.com> wrote:
> Global functions should include their prototypes.
thanks, i've applied all three cleanup patches of yours.
one minor detail:
> +struct pt_regs * save_v86_state(struct kernel_vm86_regs *);
the proper form is:
struct pt_regs *save_v86_state(struct kernel_vm86_regs *);
(note the lack of space)
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-02-02 9:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-02 7:48 [PATCH 2/3] x86: add function prototype to vm86.h Harvey Harrison
2008-02-02 8:14 ` Li Zefan
2008-02-02 8:27 ` Harvey Harrison
2008-02-02 9:04 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox