From: Harvey Harrison <harvey.harrison@gmail.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] x86: add function prototype to vm86.h
Date: Sat, 02 Feb 2008 00:27:49 -0800 [thread overview]
Message-ID: <1201940869.1844.14.camel@brick> (raw)
In-Reply-To: <47A42662.6090702@cn.fujitsu.com>
On Sat, 2008-02-02 at 16:14 +0800, Li Zefan wrote:
> Harvey Harrison 写道:
> > Global functions should include their prototypes.
> >
> > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> > ---
> > include/asm-x86/vm86.h | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/asm-x86/vm86.h b/include/asm-x86/vm86.h
> > index a5edf51..b72b9a6 100644
> > --- a/include/asm-x86/vm86.h
> > +++ b/include/asm-x86/vm86.h
> > @@ -195,6 +195,7 @@ struct kernel_vm86_struct {
> >
> > void handle_vm86_fault(struct kernel_vm86_regs *, long);
> > int handle_vm86_trap(struct kernel_vm86_regs *, long, int);
> > +struct pt_regs * save_v86_state(struct kernel_vm86_regs *);
> >
>
> This fixes a sparse warning, but contribute to a coding style error.
> checkpatch.pl complains about this patch.
Bugger, thought I caught that. Hopefully Ingo will delete the extra
space when applying, otherwise I'll send a replacement.
My apologies,
Harvey
next prev parent reply other threads:[~2008-02-02 8:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-02 7:48 [PATCH 2/3] x86: add function prototype to vm86.h Harvey Harrison
2008-02-02 8:14 ` Li Zefan
2008-02-02 8:27 ` Harvey Harrison [this message]
2008-02-02 9:04 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201940869.1844.14.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox