From: Harvey Harrison <harvey.harrison@gmail.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Andi Kleen <ak@suse.de>, Jan Beulich <jbeulich@novell.com>,
Eduardo Pereira Habkost <ehabkost@redhat.com>,
Ian Campbell <ijc@hellion.org.uk>, H Peter Anvin <hpa@zytor.com>
Subject: Re: [PATCH 1 of 7] x86: convert pgalloc_64.h from macros to inlines
Date: Sat, 02 Feb 2008 01:13:50 -0800 [thread overview]
Message-ID: <1201943630.1844.17.camel@brick> (raw)
In-Reply-To: <0d893168b08e5e0d24c2.1201943113@localhost>
On Sat, 2008-02-02 at 01:05 -0800, Jeremy Fitzhardinge wrote:
>
> -#define __pte_free_tlb(tlb,pte) tlb_remove_page((tlb),(pte))
> -
> -#define __pmd_free_tlb(tlb,x) tlb_remove_page((tlb),virt_to_page(x))
> -#define __pud_free_tlb(tlb,x) tlb_remove_page((tlb),virt_to_page(x))
> +extern void __pte_free_tlb(struct mmu_gather *tlb, struct page *pte);
> +extern void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd);
> +extern void __pud_free_tlb(struct mmu_gather *tlb, pud_t *pud);
Small question: the extern isn't necessary in headers, is it preferred
in linux anyway?
Harvey
next prev parent reply other threads:[~2008-02-02 9:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-02 9:05 [PATCH 0 of 7] x86: more pgalloc unification Jeremy Fitzhardinge
2008-02-02 9:05 ` [PATCH 1 of 7] x86: convert pgalloc_64.h from macros to inlines Jeremy Fitzhardinge
2008-02-02 9:13 ` Harvey Harrison [this message]
2008-02-02 9:17 ` Ingo Molnar
2008-02-02 9:05 ` [PATCH 2 of 7] x86: add common mm/pgtable.c Jeremy Fitzhardinge
2008-02-02 10:30 ` Ingo Molnar
2008-02-02 11:49 ` Jeremy Fitzhardinge
2008-02-02 13:47 ` Ingo Molnar
2008-02-02 16:25 ` Jeremy Fitzhardinge
2008-02-02 17:29 ` Ingo Molnar
2008-02-02 18:21 ` Jeremy Fitzhardinge
2008-02-02 9:05 ` [PATCH 3 of 7] x86: put paravirt stubs into common asm/pgalloc.h Jeremy Fitzhardinge
2008-02-02 9:05 ` [PATCH 4 of 7] x86: move pte functions " Jeremy Fitzhardinge
2008-02-02 9:21 ` Ingo Molnar
2008-02-02 9:05 ` [PATCH 5 of 7] x86: move pmd " Jeremy Fitzhardinge
2008-02-02 9:05 ` [PATCH 6 of 7] x86: move pud/pgd " Jeremy Fitzhardinge
2008-02-02 10:13 ` Ingo Molnar
2008-02-02 10:14 ` Ingo Molnar
2008-02-02 10:20 ` Jeremy Fitzhardinge
2008-02-02 10:40 ` Ingo Molnar
2008-02-02 11:49 ` Jeremy Fitzhardinge
2008-02-02 10:21 ` Ingo Molnar
2008-02-02 9:05 ` [PATCH 7 of 7] x86: move all the pgd_list handling to one place Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201943630.1844.17.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=ak@suse.de \
--cc=ehabkost@redhat.com \
--cc=hpa@zytor.com \
--cc=ijc@hellion.org.uk \
--cc=jbeulich@novell.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox