From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753046AbYBCT5V (ORCPT ); Sun, 3 Feb 2008 14:57:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751498AbYBCT5L (ORCPT ); Sun, 3 Feb 2008 14:57:11 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:57923 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751694AbYBCT5L (ORCPT ); Sun, 3 Feb 2008 14:57:11 -0500 Subject: Re: [PATCH] lockdep: Include all lock classes in all_lock_classes From: Peter Zijlstra To: Dale Farnsworth Cc: Ingo Molnar , linux-kernel@vger.kernel.org In-Reply-To: <20080203194756.GA28783@farnsworth.org> References: <20080201152106.GA21534@farnsworth.org> <1202052062.32654.69.camel@lappy> <20080203194756.GA28783@farnsworth.org> Content-Type: text/plain Date: Sun, 03 Feb 2008 20:57:01 +0100 Message-Id: <1202068623.32654.74.camel@lappy> Mime-Version: 1.0 X-Mailer: Evolution 2.21.5 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2008-02-03 at 12:47 -0700, Dale Farnsworth wrote: > On Sun, Feb 03, 2008 at 04:21:02PM +0100, Peter Zijlstra wrote: > > On Fri, 2008-02-01 at 08:21 -0700, Dale Farnsworth wrote: > > > Add each lock class to the all_lock_classes list when it is > > > first registered. > > > > > > Previously, lock classes were added to all_lock_classes when > > > the lock class was first used. > > > > > Since one of the uses of the list is to find unused locks, this didn't > > > work well. > > > > You mean in lockdep_proc.c to generate the statistics? > > Yes, that's where I noticed it. On my platform, there was one > unused lock which was missed. OK, I'll clarify the description and take the patch. Thanks!