Re: Xilinx: hwicap driver comments

Andrew Morton
2008-02-07T21:24:36Z

On Thu, 7 Feb 2008 13:54:06 -0700
"Grant Likely" <grant.likely@secretlab.ca> wrote:

> On 2/7/08, Andrew Morton <akpm@linux-foundation.org> wrote:
> > On Thu, 07 Feb 2008 21:08:50 +0100
> > How it got from there into Linux is also a mystery. I see a batch of
> > powerpc updates just went into mainline but I don't know whose tree was
> > pulled - I wasn't copied on any pull request and I can't find one on the
> > kernel mailing list.
> >
> > Perhaps Paul has just done a stealth merge, but the patch to which you
> > refer doesn't have his signoff. Very confused.
>
> It went through my tree. Paul pulls from Josh Boyer's tree for
> powerpc-4xx patches, and Josh pulls from mine for xilinx virtex
> powerpc 405 patches.
>
> My screw up, sorry I broke the rules. What is the best way to resolve this?
>

Well I think we'd like to see the patches appear in Paul's tree well before
the merge window if poss - that way they'll get a little bit of tyre-kicking
and perhaps review via -mm. Kamalesh and I (at least) do perform build-
and runtime testing of powerpc.

I would request that Paul copy myself and the main mailing list on pull
requests.

It seems wrong that the signoff trail for that patch didn't actually
reflect reality - it should have had both Josh's and Paul's signoffs. That
would require that the changelog be altered during git->git transfers which
I expect is just incompatible with the way git works (as far as I dimly
understand it).

It never hurts to send a patch to lkml even if you believe it isn't of
general interest. People will pass an idle eye across it, and things might
get picked up, yielding improvements. Plus more people know about its
existence. Probably this is more the case for something which resides
under drivers/char/ than with something which resides in arch/powerpc/...