Re: Xilinx: hwicap driver comments

Grant Likely
2008-02-07T21:31:41Z

On 2/7/08, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Thu, 7 Feb 2008 13:54:06 -0700
> "Grant Likely" <grant.likely@secretlab.ca> wrote:
> >
> > It went through my tree. Paul pulls from Josh Boyer's tree for
> > powerpc-4xx patches, and Josh pulls from mine for xilinx virtex
> > powerpc 405 patches.
> >
> > My screw up, sorry I broke the rules. What is the best way to resolve this?
> >
>
> Well I think we'd like to see the patches appear in Paul's tree well before
> the merge window if poss - that way they'll get a little bit of tyre-kicking
> and perhaps review via -mm. Kamalesh and I (at least) do perform build-
> and runtime testing of powerpc.

Fair enough. I can do so in the future.

> I would request that Paul copy myself and the main mailing list on pull
> requests.
>
> It seems wrong that the signoff trail for that patch didn't actually
> reflect reality - it should have had both Josh's and Paul's signoffs. That
> would require that the changelog be altered during git->git transfers which
> I expect is just incompatible with the way git works (as far as I dimly
> understand it).
>
> It never hurts to send a patch to lkml even if you believe it isn't of
> general interest. People will pass an idle eye across it, and things might
> get picked up, yielding improvements. Plus more people know about its
> existence. Probably this is more the case for something which resides
> under drivers/char/ than with something which resides in arch/powerpc/...

ok

Cheers,
g.

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.