From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi_error: Fix language abuse.
Date: Fri, 08 Feb 2008 09:57:27 -0600 [thread overview]
Message-ID: <1202486247.3102.17.camel@localhost.localdomain> (raw)
In-Reply-To: <20080208153217.5fc42a50@core>
On Fri, 2008-02-08 at 15:32 +0000, Alan Cox wrote:
> The word "illegal" has a precise dictionary meaning of "prohibited by
> law". The error messages are therefore incorrect as so far nobody has
> made SCSI violations a criminal offence.
Um, I'm really reluctant to do this without an incredibly good reason.
Illegal is a defined term under the SCSI standards, and the messages you
are changing actually appear with the word Illegal in the actual
ASC/ASCQ definition. If I accept this patch, you'll no longer be able
to look the messages up in the relevant standard:
http://www.t10.org/ftp/t10/drafts/spc3/spc3r23.pdf
By a simple text search.
I don't think the pedantry is worth the confusion ...
James
next prev parent reply other threads:[~2008-02-08 15:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 15:32 [PATCH] scsi_error: Fix language abuse Alan Cox
2008-02-08 15:57 ` James Bottomley [this message]
2008-02-08 15:59 ` Alan Cox
2008-02-08 16:28 ` James Bottomley
2008-02-08 16:07 ` linux-os (Dick Johnson)
2008-02-08 16:27 ` Mark Hounschell
2008-02-11 16:07 ` linux-os (Dick Johnson)
2008-02-11 17:13 ` Benny Halevy
2008-02-09 1:32 ` Douglas Gilbert
2008-02-09 13:50 ` Alan Cox
2008-02-10 23:24 ` Douglas Gilbert
2008-02-10 23:47 ` Matthew Wilcox
2008-02-09 8:02 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202486247.3102.17.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox