* [PATCH 1/2] x86: sparse warning in efi.c
@ 2008-02-13 21:26 Harvey Harrison
2008-02-16 18:10 ` Thomas Gleixner
0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2008-02-13 21:26 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Thomas Gleixner, H. Peter Anvin, LKML
arch/x86/kernel/efi.c:57:12: warning: symbol 'efi_phys' was not declared. Should it be static?
Yes, it should.
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
arch/x86/kernel/efi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/efi.c b/arch/x86/kernel/efi.c
index cbdf9ba..0de0cf5 100644
--- a/arch/x86/kernel/efi.c
+++ b/arch/x86/kernel/efi.c
@@ -54,7 +54,7 @@ EXPORT_SYMBOL(efi);
struct efi_memory_map memmap;
-struct efi efi_phys __initdata;
+static struct efi efi_phys __initdata;
static efi_system_table_t efi_systab __initdata;
static int __init setup_noefi(char *arg)
--
1.5.4.1.1278.gc75be
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] x86: sparse warning in efi.c
2008-02-13 21:26 [PATCH 1/2] x86: sparse warning in efi.c Harvey Harrison
@ 2008-02-16 18:10 ` Thomas Gleixner
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Gleixner @ 2008-02-16 18:10 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Ingo Molnar, H. Peter Anvin, LKML
On Wed, 13 Feb 2008, Harvey Harrison wrote:
> arch/x86/kernel/efi.c:57:12: warning: symbol 'efi_phys' was not declared. Should it be static?
>
> Yes, it should.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Applied. Thanks,
tglx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-16 18:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-13 21:26 [PATCH 1/2] x86: sparse warning in efi.c Harvey Harrison
2008-02-16 18:10 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox