* [PATCH 2/2] x86: sparse error in efi_32.c
@ 2008-02-13 21:26 Harvey Harrison
2008-02-16 18:11 ` Thomas Gleixner
0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2008-02-13 21:26 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Thomas Gleixner, H. Peter Anvin, LKML
include/linux/efi.h does not include asm/efi.h, efi.c and efi_64.c
explicitly include both. While not really right, add the include
to efi_32.c until the header gets sorted out.
arch/x86/kernel/efi_32.c:42:6: warning: symbol 'efi_call_phys_prelog' was not declared. Should it be static?
arch/x86/kernel/efi_32.c:84:6: warning: symbol 'efi_call_phys_epilog' was not declared. Should it be static?
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
arch/x86/kernel/efi_32.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/efi_32.c b/arch/x86/kernel/efi_32.c
index cb91f98..5d23d85 100644
--- a/arch/x86/kernel/efi_32.c
+++ b/arch/x86/kernel/efi_32.c
@@ -28,6 +28,7 @@
#include <asm/page.h>
#include <asm/pgtable.h>
#include <asm/tlbflush.h>
+#include <asm/efi.h>
/*
* To make EFI call EFI runtime service in physical addressing mode we need
--
1.5.4.1.1278.gc75be
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] x86: sparse error in efi_32.c
2008-02-13 21:26 [PATCH 2/2] x86: sparse error in efi_32.c Harvey Harrison
@ 2008-02-16 18:11 ` Thomas Gleixner
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Gleixner @ 2008-02-16 18:11 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Ingo Molnar, H. Peter Anvin, LKML
On Wed, 13 Feb 2008, Harvey Harrison wrote:
> include/linux/efi.h does not include asm/efi.h, efi.c and efi_64.c
> explicitly include both. While not really right, add the include
> to efi_32.c until the header gets sorted out.
>
> arch/x86/kernel/efi_32.c:42:6: warning: symbol 'efi_call_phys_prelog' was not declared. Should it be static?
> arch/x86/kernel/efi_32.c:84:6: warning: symbol 'efi_call_phys_epilog' was not declared. Should it be static?
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Applied. Thanks
tglx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-16 18:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-13 21:26 [PATCH 2/2] x86: sparse error in efi_32.c Harvey Harrison
2008-02-16 18:11 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox