* [PATCH] adfs: trivial sparse fix
@ 2008-02-14 2:07 Harvey Harrison
2008-02-14 3:39 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Harvey Harrison @ 2008-02-14 2:07 UTC (permalink / raw)
To: Russell King, Andrew Morton; +Cc: LKML
fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound statement
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
fs/adfs/dir_f.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/adfs/dir_f.c b/fs/adfs/dir_f.c
index b9b2b27..ea7df21 100644
--- a/fs/adfs/dir_f.c
+++ b/fs/adfs/dir_f.c
@@ -122,9 +122,9 @@ adfs_dir_checkbyte(const struct adfs_dir *dir)
ptr.ptr8 = bufoff(bh, i);
end.ptr8 = ptr.ptr8 + last - i;
- do
+ do {
dircheck = *ptr.ptr8++ ^ ror13(dircheck);
- while (ptr.ptr8 < end.ptr8);
+ } while (ptr.ptr8 < end.ptr8);
}
/*
--
1.5.4.1.1278.gc75be
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] adfs: trivial sparse fix
2008-02-14 2:07 [PATCH] adfs: trivial sparse fix Harvey Harrison
@ 2008-02-14 3:39 ` Andrew Morton
2008-02-14 3:52 ` Harvey Harrison
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2008-02-14 3:39 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Russell King, LKML
On Wed, 13 Feb 2008 18:07:48 -0800 Harvey Harrison <harvey.harrison@gmail.com> wrote:
> fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound statement
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> fs/adfs/dir_f.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/adfs/dir_f.c b/fs/adfs/dir_f.c
> index b9b2b27..ea7df21 100644
> --- a/fs/adfs/dir_f.c
> +++ b/fs/adfs/dir_f.c
> @@ -122,9 +122,9 @@ adfs_dir_checkbyte(const struct adfs_dir *dir)
> ptr.ptr8 = bufoff(bh, i);
> end.ptr8 = ptr.ptr8 + last - i;
>
> - do
> + do {
> dircheck = *ptr.ptr8++ ^ ror13(dircheck);
> - while (ptr.ptr8 < end.ptr8);
> + } while (ptr.ptr8 < end.ptr8);
> }
>
eh? It's sparse which needs fixing here, surely?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] adfs: trivial sparse fix
2008-02-14 3:39 ` Andrew Morton
@ 2008-02-14 3:52 ` Harvey Harrison
2008-02-14 4:04 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Harvey Harrison @ 2008-02-14 3:52 UTC (permalink / raw)
To: Andrew Morton; +Cc: Russell King, LKML
On Wed, 2008-02-13 at 19:39 -0800, Andrew Morton wrote:
> On Wed, 13 Feb 2008 18:07:48 -0800 Harvey Harrison <harvey.harrison@gmail.com> wrote:
>
> > fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound statement
> >
> > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> > ---
> > fs/adfs/dir_f.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/fs/adfs/dir_f.c b/fs/adfs/dir_f.c
> > index b9b2b27..ea7df21 100644
> > --- a/fs/adfs/dir_f.c
> > +++ b/fs/adfs/dir_f.c
> > @@ -122,9 +122,9 @@ adfs_dir_checkbyte(const struct adfs_dir *dir)
> > ptr.ptr8 = bufoff(bh, i);
> > end.ptr8 = ptr.ptr8 + last - i;
> >
> > - do
> > + do {
> > dircheck = *ptr.ptr8++ ^ ror13(dircheck);
> > - while (ptr.ptr8 < end.ptr8);
> > + } while (ptr.ptr8 < end.ptr8);
> > }
> >
>
> eh? It's sparse which needs fixing here, surely?
Well, I only 'fixed' it this way to match the surrounding code. The
warning is a little odd.
Harvey
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] adfs: trivial sparse fix
2008-02-14 3:52 ` Harvey Harrison
@ 2008-02-14 4:04 ` Andrew Morton
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2008-02-14 4:04 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Russell King, LKML
On Wed, 13 Feb 2008 19:52:12 -0800 Harvey Harrison <harvey.harrison@gmail.com> wrote:
> On Wed, 2008-02-13 at 19:39 -0800, Andrew Morton wrote:
> > On Wed, 13 Feb 2008 18:07:48 -0800 Harvey Harrison <harvey.harrison@gmail.com> wrote:
> >
> > > fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound statement
> > >
> > > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> > > ---
> > > fs/adfs/dir_f.c | 4 ++--
> > > 1 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/fs/adfs/dir_f.c b/fs/adfs/dir_f.c
> > > index b9b2b27..ea7df21 100644
> > > --- a/fs/adfs/dir_f.c
> > > +++ b/fs/adfs/dir_f.c
> > > @@ -122,9 +122,9 @@ adfs_dir_checkbyte(const struct adfs_dir *dir)
> > > ptr.ptr8 = bufoff(bh, i);
> > > end.ptr8 = ptr.ptr8 + last - i;
> > >
> > > - do
> > > + do {
> > > dircheck = *ptr.ptr8++ ^ ror13(dircheck);
> > > - while (ptr.ptr8 < end.ptr8);
> > > + } while (ptr.ptr8 < end.ptr8);
> > > }
> > >
> >
> > eh? It's sparse which needs fixing here, surely?
>
> Well, I only 'fixed' it this way to match the surrounding code. The
> warning is a little odd.
>
Yup, well, I changed the title to something sufficiently rude to get a
reaction from Linus when it crosses his desk. We'll see ;)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-02-14 4:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-14 2:07 [PATCH] adfs: trivial sparse fix Harvey Harrison
2008-02-14 3:39 ` Andrew Morton
2008-02-14 3:52 ` Harvey Harrison
2008-02-14 4:04 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox