From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758057AbYBPVLw (ORCPT ); Sat, 16 Feb 2008 16:11:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756666AbYBPVLm (ORCPT ); Sat, 16 Feb 2008 16:11:42 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:47454 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756630AbYBPVLl (ORCPT ); Sat, 16 Feb 2008 16:11:41 -0500 Subject: Re: [PATCH 2/3] sched: trivial sparse warning in sched.c From: Peter Zijlstra To: Harvey Harrison Cc: Ingo Molnar , LKML In-Reply-To: <1203098196.15275.5.camel@brick> References: <1203098196.15275.5.camel@brick> Content-Type: text/plain Date: Sat, 16 Feb 2008 22:11:29 +0100 Message-Id: <1203196289.6301.20.camel@lappy> Mime-Version: 1.0 X-Mailer: Evolution 2.21.90 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2008-02-15 at 09:56 -0800, Harvey Harrison wrote: > kernel/sched.c:3680:3: warning: returning void-valued expression I'm wondering,... why is this wrong? > Signed-off-by: Harvey Harrison > --- > kernel/sched.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/kernel/sched.c b/kernel/sched.c > index f28f19e..824d5a9 100644 > --- a/kernel/sched.c > +++ b/kernel/sched.c > @@ -3676,8 +3676,10 @@ void account_system_time(struct task_struct *p, int hardirq_offset, > struct rq *rq = this_rq(); > cputime64_t tmp; > > - if ((p->flags & PF_VCPU) && (irq_count() - hardirq_offset == 0)) > - return account_guest_time(p, cputime); > + if ((p->flags & PF_VCPU) && (irq_count() - hardirq_offset == 0)) { > + account_guest_time(p, cputime); > + return; > + } > > p->stime = cputime_add(p->stime, cputime); >