From: Joe Perches <joe@perches.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86: Coding style fixes for arch/x86/kernel/cpu/centaur.c
Date: Sun, 17 Feb 2008 19:12:24 -0800 [thread overview]
Message-ID: <1203304344.7181.45.camel@localhost> (raw)
In-Reply-To: <20080218025645.GB30201@elte.hu>
On Mon, 2008-02-18 at 03:56 +0100, Ingo Molnar wrote:
> arch/x86/kernel/cpu/centaur.c | 394 +++++++++++++++++++++---------------------
> 1 file changed, 199 insertions(+), 195 deletions(-)
>
> Index: linux-x86.q/arch/x86/kernel/cpu/centaur.c
> ===================================================================
> --- linux-x86.q.orig/arch/x86/kernel/cpu/centaur.c
> +++ linux-x86.q/arch/x86/kernel/cpu/centaur.c
> @@ -52,13 +54,12 @@ static u32 __cpuinit ramtop(void) /* 16
> if (e820.map[i].addr > 0xFFFFFFFFUL)
> continue;
> /*
> - * Don't MCR over reserved space. Ignore the ISA hole
> - * we frob around that catastrophe already
> + * Don't MCR over reserved space. Ignore the ISA hole
> + * we frob around that catastrophe already
> */
> -
> - if (e820.map[i].type == E820_RESERVED)
> - {
> - if (e820.map[i].addr >= 0x100000UL && e820.map[i].addr < clip)
> + if (e820.map[i].type == E820_RESERVED) {
> + if (e820.map[i].addr >= 0x100000UL &&
> + e820.map[i].addr < clip)
> clip = e820.map[i].addr;
Doesn't this look better as:
+ if (e820.map[i].addr >= 0x100000UL &&
+ e820.map[i].addr < clip)
next prev parent reply other threads:[~2008-02-18 3:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080217233023.26764dc9@paolo-desktop>
2008-02-18 2:56 ` [PATCH] x86: Coding style fixes for arch/x86/kernel/cpu/centaur.c Ingo Molnar
2008-02-18 3:12 ` Joe Perches [this message]
2008-02-18 4:30 ` Ingo Molnar
2008-02-18 8:48 ` Paolo Ciarrocchi
2008-02-18 9:29 ` Ingo Molnar
2008-02-18 9:38 ` Paolo Ciarrocchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203304344.7181.45.camel@localhost \
--to=joe@perches.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paolo.ciarrocchi@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox