* [PATCH] driver-core: fix kernel-doc function parameters
@ 2008-02-18 21:09 Randy Dunlap
2008-02-19 23:03 ` patch driver-core-fix-kernel-doc-function-parameters.patch added to gregkh-2.6 tree gregkh
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2008-02-18 21:09 UTC (permalink / raw)
To: lkml; +Cc: gregkh
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix drivers/base/ missing kernel-doc parameters:
Warning(linux-2.6.24-git12//drivers/base/driver.c:133): No description found for parameter 'drv'
Warning(linux-2.6.24-git12//drivers/base/driver.c:133): No description found for parameter 'kobj'
Warning(linux-2.6.24-git12//drivers/base/driver.c:133): No description found for parameter 'fmt'
Warning(linux-2.6.24-git12//drivers/base/power/main.c:530): No description found for parameter 'state'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/base/driver.c | 3 +++
drivers/base/power/main.c | 1 +
2 files changed, 4 insertions(+)
--- linux-2.6.25-rc1-git4.orig/drivers/base/driver.c
+++ linux-2.6.25-rc1-git4/drivers/base/driver.c
@@ -120,6 +120,9 @@ EXPORT_SYMBOL_GPL(driver_remove_file);
/**
* driver_add_kobj - add a kobject below the specified driver
+ * @drv: requesting device driver
+ * @kobj: kobject to add below this driver
+ * @fmt: format string that names the kobject
*
* You really don't want to do this, this is only here due to one looney
* iseries driver, go poke those developers if you are annoyed about
--- linux-2.6.25-rc1-git4.orig/drivers/base/power/main.c
+++ linux-2.6.25-rc1-git4/drivers/base/power/main.c
@@ -523,6 +523,7 @@ static void lock_all_devices(void)
/**
* device_suspend - Save state and stop all devices in system.
+ * @state: new power management state
*
* Prevent new devices from being registered, then lock all devices
* and suspend them.
^ permalink raw reply [flat|nested] 2+ messages in thread
* patch driver-core-fix-kernel-doc-function-parameters.patch added to gregkh-2.6 tree
2008-02-18 21:09 [PATCH] driver-core: fix kernel-doc function parameters Randy Dunlap
@ 2008-02-19 23:03 ` gregkh
0 siblings, 0 replies; 2+ messages in thread
From: gregkh @ 2008-02-19 23:03 UTC (permalink / raw)
To: randy.dunlap, greg, gregkh, linux-kernel
This is a note to let you know that I've just added the patch titled
Subject: [PATCH] driver-core: fix kernel-doc function parameters
to my gregkh-2.6 tree. Its filename is
driver-core-fix-kernel-doc-function-parameters.patch
This tree can be found at
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/
>From randy.dunlap@oracle.com Mon Feb 18 13:09:55 2008
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Mon, 18 Feb 2008 13:09:03 -0800
Subject: [PATCH] driver-core: fix kernel-doc function parameters
To: lkml <linux-kernel@vger.kernel.org>
Cc: gregkh <greg@kroah.com>
Message-ID: <20080218130903.ae375db8.randy.dunlap@oracle.com>
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix drivers/base/ missing kernel-doc parameters:
Warning(linux-2.6.24-git12//drivers/base/driver.c:133): No description found for parameter 'drv'
Warning(linux-2.6.24-git12//drivers/base/driver.c:133): No description found for parameter 'kobj'
Warning(linux-2.6.24-git12//drivers/base/driver.c:133): No description found for parameter 'fmt'
Warning(linux-2.6.24-git12//drivers/base/power/main.c:530): No description found for parameter 'state'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/base/driver.c | 3 +++
drivers/base/power/main.c | 1 +
2 files changed, 4 insertions(+)
--- a/drivers/base/driver.c
+++ b/drivers/base/driver.c
@@ -120,6 +120,9 @@ EXPORT_SYMBOL_GPL(driver_remove_file);
/**
* driver_add_kobj - add a kobject below the specified driver
+ * @drv: requesting device driver
+ * @kobj: kobject to add below this driver
+ * @fmt: format string that names the kobject
*
* You really don't want to do this, this is only here due to one looney
* iseries driver, go poke those developers if you are annoyed about
--- a/drivers/base/power/main.c
+++ b/drivers/base/power/main.c
@@ -523,6 +523,7 @@ static void lock_all_devices(void)
/**
* device_suspend - Save state and stop all devices in system.
+ * @state: new power management state
*
* Prevent new devices from being registered, then lock all devices
* and suspend them.
Patches currently in gregkh-2.6 which might be from randy.dunlap@oracle.com are
driver/driver-core-fix-kernel-doc-function-parameters.patch
pci/pci-kernel-doc-fix-pci-acpi-warning.patch
usb/usb-convert-usb.h-struct-usb_device-to-kernel-doc.patch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-19 23:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-18 21:09 [PATCH] driver-core: fix kernel-doc function parameters Randy Dunlap
2008-02-19 23:03 ` patch driver-core-fix-kernel-doc-function-parameters.patch added to gregkh-2.6 tree gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox