From: Harvey Harrison <harvey.harrison@gmail.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: Zhang Rui <rui.zhang@intel.com>,
Thomas Sujith <sujith.thomas@intel.com>,
Len Brown <len.brown@intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/thermal/thermal.c: fix a check-after-use
Date: Tue, 19 Feb 2008 16:25:02 -0800 [thread overview]
Message-ID: <1203467102.23194.2.camel@brick> (raw)
In-Reply-To: <20080220001404.GW31955@cs181133002.pp.htv.fi>
On Wed, 2008-02-20 at 02:14 +0200, Adrian Bunk wrote:
> This patch fixes a check-after-use spotted by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
> 570462ca4441d8d63dfd46efe6e5b2b1c251a611 diff --git a/drivers/thermal/thermal.c b/drivers/thermal/thermal.c
> index e782b3e..958654b 100644
> --- a/drivers/thermal/thermal.c
> +++ b/drivers/thermal/thermal.c
> @@ -308,10 +308,10 @@ int thermal_zone_bind_cooling_device(struct thermal_zone_device *tz,
> struct thermal_cooling_device_instance *pos;
> int result;
>
> - if (trip >= tz->trips || (trip < 0 && trip != THERMAL_TRIPS_NONE))
> + if (!tz || !cdev)
> return -EINVAL;
>
> - if (!tz || !cdev)
> + if (trip >= tz->trips || (trip < 0 && trip != THERMAL_TRIPS_NONE))
> return -EINVAL;
>
How about:
if (!tz || !cdev || trip >= tz->trips ||
(trip < 0 && trip != THERMAL_TRIPS_NONE))
return -EINVAL;
Cheers,
Harvey
next prev parent reply other threads:[~2008-02-20 0:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 0:14 [2.6 patch] drivers/thermal/thermal.c: fix a check-after-use Adrian Bunk
2008-02-20 0:25 ` Harvey Harrison [this message]
2008-02-20 0:26 ` Adrian Bunk
2008-02-23 7:19 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203467102.23194.2.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=bunk@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=sujith.thomas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox