PL2303 Driver missing support for USB to Serial Cable

PL2303 Driver missing support for USB to Serial Cable

[Stephan Rose]

I recently purchased a USB->Com Port serial cable from Radio Shack
(Model number 26-183) which did no seem to want to work. After looking
into it I discovered that it is based on the Prolific chipset using the
PL2303 driver. 

I then checked the Vendor and Product ID against the list in the drive
and sure enough, the IDs were missing in the driver.

So here are my modifications to the PL2303 driver which have been
working flawlessly on my system the whole week:

drivers/usb/serial/pl2303.h
--------

/* Radio Shack 26-183 */
#define RADIOSHACK26183_VENDOR_ID 0x05ad
#define RADIOSHACK26183_PRODUCT_ID 0x0fba

drivers/usb/serial/pl2303.c
--------

Added to struct usb_device_id id_table

{ USB_DEVICE(RADIOSHACK26183_VENDOR_ID RADIOSHACK26183_PRODUCT_ID) }

I still have to manually modprobe the module as the kernel won't
automatically load it when I connect the device, no idea what I would
need to change where for that to happen.

The above though does successfully add support for that serial cable so
I thought I'd share it with the kernel list so that it can possibly be
added to the kernel and I can stop having to re-compile the driver every
kernel update. :)

Please feel free to contact me if needed.

Thanks!

Stephan

Re: PL2303 Driver missing support for USB to Serial Cable

[Jiri Slaby]

On 02/14/2008 03:57 PM, Stephan Rose wrote:
> I recently purchased a USB->Com Port serial cable from Radio Shack
> (Model number 26-183) which did no seem to want to work. After looking
> into it I discovered that it is based on the Prolific chipset using the
> PL2303 driver. 
> 
> I then checked the Vendor and Product ID against the list in the drive
> and sure enough, the IDs were missing in the driver.
> 
> So here are my modifications to the PL2303 driver which have been
> working flawlessly on my system the whole week:
> 
> drivers/usb/serial/pl2303.h
> --------
> 
> /* Radio Shack 26-183 */
> #define RADIOSHACK26183_VENDOR_ID 0x05ad
> #define RADIOSHACK26183_PRODUCT_ID 0x0fba
> 
> drivers/usb/serial/pl2303.c
> --------
> 
> Added to struct usb_device_id id_table
> 
> { USB_DEVICE(RADIOSHACK26183_VENDOR_ID RADIOSHACK26183_PRODUCT_ID) }
> 
> I still have to manually modprobe the module as the kernel won't
> automatically load it when I connect the device, no idea what I would
> need to change where for that to happen.
> 
> The above though does successfully add support for that serial cable so
> I thought I'd share it with the kernel list so that it can possibly be
> added to the kernel and I can stop having to re-compile the driver every
> kernel update. :)

Well, would you mind creating, testing and posting a patch?

Re: PL2303 Driver missing support for USB to Serial Cable

[David Newall]

Stephan,

Jiri Slaby wrote:
> On 02/14/2008 03:57 PM, Stephan Rose wrote:
>> I recently purchased a USB->Com Port serial cable from Radio Shack
>> (Model number 26-183) which did no seem to want to work. After looking
>> into it I discovered that it is based on the Prolific chipset using the
>> PL2303 driver.
>
> Well, would you mind creating, testing and posting a patch?


You needn't bother.  As far as I'm concerned, what you sent is
sufficient and, as I am currently working on the pl2303 driver, you can
rest assured that it will be included in the patch that I send.

Regards,

David

Re: PL2303 Driver missing support for USB to Serial Cable

[Greg KH]

On Sat, Feb 16, 2008 at 11:35:16PM +1030, David Newall wrote:
> Stephan,
> 
> Jiri Slaby wrote:
> > On 02/14/2008 03:57 PM, Stephan Rose wrote:
> >> I recently purchased a USB->Com Port serial cable from Radio Shack
> >> (Model number 26-183) which did no seem to want to work. After looking
> >> into it I discovered that it is based on the Prolific chipset using the
> >> PL2303 driver.
> >
> > Well, would you mind creating, testing and posting a patch?
> 
> 
> You needn't bother.  As far as I'm concerned, what you sent is
> sufficient and, as I am currently working on the pl2303 driver, you can
> rest assured that it will be included in the patch that I send.

That might be pretty tough to do, as it's already in the 2.6.25-rc2
release :)

And please, patches need to be one-thing-per-patch.  Don't try to mix
cleanups, bug fixes, and also new devices ids all in one patch.

Stephan, thanks for the report, but someone beat you to it by a few
weeks already, the driver is updated.

thanks,

greg k-h

Re: PL2303 Driver missing support for USB to Serial Cable

[Stephan Rose]

On Sun, 2008-02-17 at 21:06 -0800, Greg KH wrote:
> On Sat, Feb 16, 2008 at 11:35:16PM +1030, David Newall wrote:
> > Stephan,
> > 
> > Jiri Slaby wrote:
> > > On 02/14/2008 03:57 PM, Stephan Rose wrote:
> > >> I recently purchased a USB->Com Port serial cable from Radio Shack
> > >> (Model number 26-183) which did no seem to want to work. After looking
> > >> into it I discovered that it is based on the Prolific chipset using the
> > >> PL2303 driver.
> > >
> > > Well, would you mind creating, testing and posting a patch?
> > 
> > 
> > You needn't bother.  As far as I'm concerned, what you sent is
> > sufficient and, as I am currently working on the pl2303 driver, you can
> > rest assured that it will be included in the patch that I send.
> 
> That might be pretty tough to do, as it's already in the 2.6.25-rc2
> release :)
> 
> And please, patches need to be one-thing-per-patch.  Don't try to mix
> cleanups, bug fixes, and also new devices ids all in one patch.
> 
> Stephan, thanks for the report, but someone beat you to it by a few
> weeks already, the driver is updated.

No problem, glad it's already in! :)

Thanks,

Stephan