RE: printk_ratelimit and net_ratelimit conflict and tunable behavior

Joe Perches
2008-02-26T00:05:18Z

On Mon, 2008-02-25 at 17:49 -0600, Hawkes Steve-FSH016 wrote:
> Are you saying the few lines of code to handle changes to the tunables
> aren't worth keeping?

Yes.

I think the tunables, if needed at all, should be set by modifying
the struct and the call might as well be:

bool __printk_ratelimit(struct printk_ratelimit_state *state)

Another quibble is not directed to your change because it's
preexisting but "tok" isn't a good name and may not even need
to be in the structure. It does save a multiply though.

I think that anything that attempts a printk is slow path
so it doesn't matter much though.