public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: balbir@linux.vnet.ibm.com
Cc: Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <peter@programming.kicks-ass.net>,
	Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
	Dhaval Giani <dhaval@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: Make yield_task_fair more efficient
Date: Thu, 21 Feb 2008 09:43:59 +0100	[thread overview]
Message-ID: <1203583439.6243.119.camel@lappy> (raw)
In-Reply-To: <47BD2A99.3010608@linux.vnet.ibm.com>


On Thu, 2008-02-21 at 13:09 +0530, Balbir Singh wrote:

> sched_yield() is supported API

For SCHED_FIFO/SCHED_RR.

>  and also look at http://lkml.org/lkml/2007/9/19/351.

Read on (http://lkml.org/lkml/2007/9/19/371) and find:
        
        The sched_yield() behaviour is actually very well-defined for RT
        tasks (now, whether it's a good interface to use or not is still
        open to debate, but at least it's a _defined_ interface ;), and
        I think we should at least try to approximate that behaviour for
        normal tasks, even if they aren't RT.

sched_yield() just isn't a very useful API except in RT and even there
one can question it.

> I am trying to make sched_yield() efficient
> when compat_sched_yield is turned on (which is most likely), since people will
> want that behaviour (Hint, please read the man-page for sched_yield).

I did, so what? read the POSIX spec - its just plain undefined for
SCHED_OTHER. We already do something 'sensible' for those few broken
applications relying on unspecified behaviour.

> There are
> already several applications using sched_yield(), so they all suffer.

Who is using it, where is their source so we can show its faster to not
use it?

Really, hiding behind closed sores doesn't make it good.



  reply	other threads:[~2008-02-21  8:44 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-21  5:33 Make yield_task_fair more efficient Balbir Singh
2008-02-21  6:04 ` Ingo Molnar
2008-02-21  6:51   ` Balbir Singh
2008-02-21  7:07     ` Ingo Molnar
2008-02-21  7:39       ` Balbir Singh
2008-02-21  8:43         ` Peter Zijlstra [this message]
2008-02-21  8:50           ` Balbir Singh
2008-02-21  9:04             ` Ingo Molnar
2008-02-21  9:31               ` Balbir Singh
2008-02-21  9:42                 ` Ingo Molnar
2008-02-21  9:44                   ` Balbir Singh
2008-02-21  9:43                 ` Peter Zijlstra
2008-02-21  9:42                   ` Balbir Singh
2008-02-21 10:01                     ` Peter Zijlstra
2008-02-21 10:07                       ` Balbir Singh
2008-02-21 11:12                         ` Peter Zijlstra
2008-02-21 11:27                           ` Balbir Singh
2008-02-21 20:38                           ` Jens Axboe
2008-02-21 20:55                             ` Jens Axboe
2008-02-22  3:27                               ` Balbir Singh
2008-02-21 10:17                 ` Balbir Singh
2008-02-21 12:02                 ` Mike Galbraith
2008-02-21 12:06                   ` Mike Galbraith
2008-02-21 13:29                   ` Balbir Singh
2008-02-21 14:38     ` Jörn Engel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1203583439.6243.119.camel@lappy \
    --to=a.p.zijlstra@chello.nl \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=dhaval@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peter@programming.kicks-ass.net \
    --cc=vatsa@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox