Re: [UPDATED v2][PATCH 0/6] regulator: voltage and current regulator framework

[Liam Girdwood <lg@opensource.wolfsonmicro.com>]

On Thu, 2008-02-21 at 08:41 +0000, Russell King - ARM Linux wrote:
> On Wed, Feb 20, 2008 at 05:08:46PM +0000, Liam Girdwood wrote:
> > This patch series provides a generic framework to allow device drivers
> > to control voltage and current regulators on SoC based devices (e.g.
> > phones, gps, media players).
> 
> Note that I'm explicitly avoiding commenting on this as far as PXA3xx
> devices go, until we're further down the road with PM support on that
> SoC.  It's not clear at present whether a generic PMIC framework will
> be suitable for this SoC since it's my understanding from Marvell that
> we need to talk to the PMIC from IRQs-off contexts.
> 
> So don't take my silence as some sort of acceptance of this code; it
> isn't.

I wasn't ;)

It then might be worth adding this functionality at a later stage when
more can be said about PXA3xx PMIC support. We could always have a
version of the _set() functions that are designed to handle this case.

In the mean time this works well on 3 other SoC CPUs.

Liam