Re: [PATCH] mac80211: check endianness/types in sparse runs

Johannes Berg
2008-02-21T20:09:50Z

[-- Attachment #1: Type: text/plain, Size: 847 bytes --]

> > In any case, I would love to have __CHECK_ENDIAN__ enabled by default at
> > least on the wireless code (just caught another bug with it...)
>
> I should then add support for something like:
>
> checkflags-y := -D__CHECK_ENDIAN__
>
> to match the style of the rest.
>
> I do not like all the buried in assumption about the
> global variables.

That might be good. I retract my patch for now then.

> But I would prefer that someone would spend a few days looking into the
> warnings generated with sparse.

I did spend a bit of time running it on all the tree, but wireless,
where I do most work, is clean. I have some code in sound/ that
generates warnings and some drivers/macintosh/ code I worked on too, but
right now I don't want to pick up too many changes all over the tree
into my patches tree.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]