public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Harvey Harrison <harvey.harrison@gmail.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] saa7146: fix sparse warnings
Date: Thu, 21 Feb 2008 13:22:06 -0800	[thread overview]
Message-ID: <1203628926.20345.73.camel@brick> (raw)
In-Reply-To: <20080221211927.GB27894@ZenIV.linux.org.uk>

On Thu, 2008-02-21 at 21:19 +0000, Al Viro wrote:
> On Thu, Feb 21, 2008 at 09:52:36AM -0800, Harvey Harrison wrote:
> 
> Could you please use more descriptive names?  NULL noise removal
> is not the same as shadowing or endianness annotations or endianness
> fixes or __user/__iomem annotations/fixes, etc.

Point taken, will do so going forward.

For now, I'm just doing the trivial ones to make the more interesting
warnings stand out a little better.

Harvey


  reply	other threads:[~2008-02-21 21:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-21 17:52 [PATCH] saa7146: fix sparse warnings Harvey Harrison
2008-02-21 21:19 ` Al Viro
2008-02-21 21:22   ` Harvey Harrison [this message]
2008-03-02 17:34 ` Dmitri Vorobiev
2008-03-02 18:06   ` Harvey Harrison
2008-03-02 18:46     ` Dmitri Vorobiev
2008-03-02 19:57     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1203628926.20345.73.camel@brick \
    --to=harvey.harrison@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox