* [PATCH 2/2] char: fix possible double-unlock in specialix.c
@ 2008-02-22 18:34 Harvey Harrison
0 siblings, 0 replies; only message in thread
From: Harvey Harrison @ 2008-02-22 18:34 UTC (permalink / raw)
To: Andrew Morton; +Cc: LKML
Noticed by sparse, trivial to see:
drivers/char/specialix.c:2112:3: warning: context imbalance in 'sx_throttle' - unexpected unlock
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
And with the torrent of warnings fixed, here we find a double-unlock.
drivers/char/specialix.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/char/specialix.c b/drivers/char/specialix.c
index 5487f37..b508e2c 100644
--- a/drivers/char/specialix.c
+++ b/drivers/char/specialix.c
@@ -2109,7 +2109,6 @@ static void sx_throttle(struct tty_struct * tty)
sx_out(bp, CD186x_CAR, port_No(port));
spin_unlock_irqrestore(&bp->lock, flags);
if (I_IXOFF(tty)) {
- spin_unlock_irqrestore(&bp->lock, flags);
sx_wait_CCR(bp);
spin_lock_irqsave(&bp->lock, flags);
sx_out(bp, CD186x_CCR, CCR_SSCH2);
--
1.5.4.2.200.g99e75
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2008-02-22 18:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-22 18:34 [PATCH 2/2] char: fix possible double-unlock in specialix.c Harvey Harrison
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox