From: Mark McLoughlin <markmc@redhat.com>
To: Ian Campbell <ijc@hellion.org.uk>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Joel Becker <Joel.Becker@oracle.com>,
Jody Belka <lists-lkml@pimb.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Andi Kleen <andi@firstfloor.org>,
Mika Penttila <mika.penttila@kolumbus.fi>
Subject: Re: 2.6.25-rc1 xen pvops regression
Date: Tue, 26 Feb 2008 17:06:32 +0000 [thread overview]
Message-ID: <1204045592.12238.6.camel@muff> (raw)
In-Reply-To: <1203665106.28436.19.camel@cthulhu.hellion.org.uk>
On Fri, 2008-02-22 at 07:25 +0000, Ian Campbell wrote:
> On Thu, 2008-02-21 at 14:58 -0800, H. Peter Anvin wrote:
> >
> > Which it is on real hardware, because although it's not *reserved*
> > (type 2), it is certainly not made available as *normal memory* (type
> > 1). If Xen maps this as type 1 then I definitely see the problem.
> >
> > We can exclude type 1 memory from DMI scan, certainly.
>
> I'd been meaning to ask this. So the machines you have which don't
> describe 0xf0000 as reserved also don't describe it as RAM? (I guess
> it's either a hole in the table or one of the other e820 types).
> Ian.
...
> >From 13bdb4ee9d80b83a81c3dbefa52464e511d1b4df Mon Sep 17 00:00:00 2001
> From: Ian Campbell <ijc@hellion.org.uk>
> Date: Fri, 22 Feb 2008 07:17:14 +0000
> Subject: [PATCH] x86: Do not scan for DMI if the DMI region is marked as RAM by e820.
>
> Under Xen the memory at 0xf0000 is regular RAM and so can potentially contain a
> page table and hence cannot be mapped. The e820 map given to guest reflects
> this.
>
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
...
> @@ -371,6 +372,9 @@ void __init dmi_scan_machine(void)
> }
> }
> else {
> + if (e820_all_mapped(0xF0000, 0xF0000+0x10000, E820_RAM))
> + goto out;
One issue with using the e820 map for this is that a Xen Dom0 will also
have this region marked as RAM in the e820 map, but will set up a fixmap
for it, allowing dmi_scan_machine() to map the region.
Cheers,
Mark.
next prev parent reply other threads:[~2008-02-26 17:08 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 23:54 2.6.25-rc1 xen pvops regression Jody Belka
2008-02-13 11:59 ` Jeremy Fitzhardinge
2008-02-13 12:13 ` Jody Belka
2008-02-13 12:23 ` Ingo Molnar
2008-02-14 2:27 ` Joel Becker
2008-02-14 7:50 ` Jeremy Fitzhardinge
2008-02-15 20:23 ` Joel Becker
2008-02-16 2:44 ` Jeremy Fitzhardinge
2008-02-16 8:54 ` Joel Becker
2008-02-16 11:46 ` Jeremy Fitzhardinge
2008-02-17 6:29 ` Joel Becker
2008-02-17 12:09 ` Jeremy Fitzhardinge
2008-02-17 6:39 ` Joel Becker
2008-02-17 18:49 ` Ian Campbell
2008-02-18 10:40 ` Joel Becker
2008-02-19 21:50 ` Ian Campbell
2008-02-19 21:59 ` Ian Campbell
2008-02-20 7:43 ` H. Peter Anvin
2008-02-20 8:51 ` Ian Campbell
2008-02-20 21:42 ` Joel Becker
2008-02-20 22:30 ` Ian Campbell
2008-02-20 21:58 ` Jeremy Fitzhardinge
2008-02-20 22:29 ` Ian Campbell
2008-02-21 21:16 ` Jeremy Fitzhardinge
2008-02-21 21:21 ` H. Peter Anvin
2008-02-21 21:37 ` Jeremy Fitzhardinge
2008-02-21 21:44 ` H. Peter Anvin
2008-02-21 22:12 ` Ian Campbell
2008-02-21 22:23 ` H. Peter Anvin
2008-02-21 22:49 ` Jeremy Fitzhardinge
2008-02-21 22:58 ` H. Peter Anvin
2008-02-22 7:25 ` Ian Campbell
2008-02-22 9:28 ` Alan Cox
2008-02-22 9:55 ` Andi Kleen
2008-02-22 10:00 ` Alan Cox
2008-02-22 10:15 ` Andi Kleen
2008-02-22 16:27 ` H. Peter Anvin
2008-02-22 19:25 ` Pavel Machek
2008-02-26 17:06 ` Mark McLoughlin [this message]
2008-02-26 20:05 ` Jeremy Fitzhardinge
2008-02-21 22:58 ` Joel Becker
2008-02-21 22:04 ` Eric W. Biederman
2008-02-21 23:14 ` Jeremy Fitzhardinge
2008-02-21 23:26 ` H. Peter Anvin
2008-02-21 23:46 ` Jeremy Fitzhardinge
2008-02-21 23:57 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204045592.12238.6.camel@muff \
--to=markmc@redhat.com \
--cc=Joel.Becker@oracle.com \
--cc=andi@firstfloor.org \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=ijc@hellion.org.uk \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lists-lkml@pimb.org \
--cc=mika.penttila@kolumbus.fi \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox