* [PATCH 3/3] sound: vmaster.c missing include of hda_local.h
@ 2008-02-29 0:18 Harvey Harrison
2008-02-29 11:07 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2008-02-29 0:18 UTC (permalink / raw)
To: Takashi Iwai; +Cc: LKML
Needed for the two prototypes, must include hda_codec.h as well
due to some dependencies between the headers.
sound/pci/hda/vmaster.c:230:5: warning: symbol 'snd_ctl_add_slave' was not declared. Should it be static?
sound/pci/hda/vmaster.c:329:21: warning: symbol 'snd_ctl_make_virtual_master' was not declared. Should it be static?
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
sound/pci/hda/vmaster.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/pci/hda/vmaster.c b/sound/pci/hda/vmaster.c
index 2da49d2..26149b5 100644
--- a/sound/pci/hda/vmaster.c
+++ b/sound/pci/hda/vmaster.c
@@ -12,6 +12,8 @@
#include <linux/slab.h>
#include <sound/core.h>
#include <sound/control.h>
+#include "hda_codec.h"
+#include "hda_local.h"
/*
* a subset of information returned via ctl info callback
--
1.5.4.3.342.g99e8
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3/3] sound: vmaster.c missing include of hda_local.h
2008-02-29 0:18 [PATCH 3/3] sound: vmaster.c missing include of hda_local.h Harvey Harrison
@ 2008-02-29 11:07 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2008-02-29 11:07 UTC (permalink / raw)
To: Harvey Harrison; +Cc: LKML
At Thu, 28 Feb 2008 16:18:11 -0800,
Harvey Harrison wrote:
>
> Needed for the two prototypes, must include hda_codec.h as well
> due to some dependencies between the headers.
> sound/pci/hda/vmaster.c:230:5: warning: symbol 'snd_ctl_add_slave' was not declared. Should it be static?
> sound/pci/hda/vmaster.c:329:21: warning: symbol 'snd_ctl_make_virtual_master' was not declared. Should it be static?
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
This isn't needed any more on the latest ALSA tree.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-29 11:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-29 0:18 [PATCH 3/3] sound: vmaster.c missing include of hda_local.h Harvey Harrison
2008-02-29 11:07 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox