Re: [patch 09/21] (NEW) improve reclaim balancing

KOSAKI Motohiro
2008-03-01T13:36:37Z

hi

> + /*
> + * Even if we did not try to evict anon pages at all, we want to
> + * rebalance the anon lru active/inactive ratio.
> + */
> + if (inactive_anon_low(zone))
> + shrink_list(NR_ACTIVE_ANON, SWAP_CLUSTER_MAX, zone, sc,
> + priority);
> +

you want check global zone status, right?
if so, this statement only do that at global scan.

- kosaki

---
mm/vmscan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Index: b/mm/vmscan.c
===================================================================
--- a/mm/vmscan.c 2008-03-01 22:18:42.000000000 +0900
+++ b/mm/vmscan.c 2008-03-01 22:42:42.000000000 +0900
@@ -1319,9 +1319,9 @@ static unsigned long shrink_zone(int pri
* Even if we did not try to evict anon pages at all, we want to
* rebalance the anon lru active/inactive ratio.
*/
- if (inactive_anon_low(zone))
+ if (scan_global_lru(sc) && inactive_anon_low(zone))
shrink_list(NR_ACTIVE_ANON, SWAP_CLUSTER_MAX, zone, sc,
priority);

throttle_vm_writeout(sc->gfp_mask);
return nr_reclaimed;