Re: [RFC/PATCH 2/4] cpuset: system sets

Max Krasnyanskiy
2008-02-27T23:53:11Z

Hmm, shouldn't patches be sent inline ?
Otherwise I need to cut&paste in order to reply.

Anyway. cpu_system_map looks fine. It's identical in functionality (minus the
notifier) to the ~cpu_isolated_map. Different name works for me.

As I explained in the prev reply I suggest we use CPU hotplug instead of the
brand new notifier mechanism that requires changes to a bunch of things, and
at the end of the day ends up doing the same exact thing. ie Moving things out
of the CPU that is being isolated.

> --- linux-2.6.orig/kernel/sched.c
> +++ linux-2.6/kernel/sched.c
> @@ -4854,6 +4854,9 @@ asmlinkage long sys_sched_setaffinity(pi
> cpumask_t cpu_present_map __read_mostly;
> EXPORT_SYMBOL(cpu_present_map);
>
> +cpumask_t cpu_system_map __read_mostly = CPU_MASK_ALL;
> +EXPORT_SYMBOL(cpu_system_map);
> +
> #ifndef CONFIG_SMP
> cpumask_t cpu_online_map __read_mostly = CPU_MASK_ALL;
> EXPORT_SYMBOL(cpu_online_map);

I beleive those masks belong in kernel/cpu.c instead of kernel/sched.c.
It can be done with a separate patch of course.

Max