The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 08/14] scsi: replace remaining __FUNCTION__ occurrences
Date: Mon, 03 Mar 2008 21:30:00 -0600	[thread overview]
Message-ID: <1204601400.3043.102.camel@localhost.localdomain> (raw)
In-Reply-To: <1204600189.22933.88.camel@brick>


On Mon, 2008-03-03 at 19:09 -0800, Harvey Harrison wrote:
> __FUNCTION__ is gcc-specific, use __func__

What on earth is the point of this?

We already have compiler specific files in 

include/linux/compiler-*

Which can be used to #define __FUNCTION__ to whatever the individual
compiler wants.  That way we don't get thousands of lines of churn in
the kernel for no value.

James



  reply	other threads:[~2008-03-04  3:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <ff8fd021606e7a6f03e9c274230cfcf64eade6d2.1204599636.git.harvey.harrison@gmail.com>
2008-03-04  3:09 ` [PATCH 02/14] drivers/char: replace remaining __FUNCTION__ occurrences Harvey Harrison
2008-03-04  3:09 ` [PATCH 03/14] input: " Harvey Harrison
2008-03-04  3:09 ` [PATCH 04/14] i2c: " Harvey Harrison
2008-03-04  9:12   ` Jean Delvare
2008-03-04  3:09 ` [PATCH 05/14] pci: " Harvey Harrison
2008-03-04  3:09 ` [PATCH 06/14] drivers/s390: " Harvey Harrison
2008-03-04  8:55   ` Martin Schwidefsky
2008-03-04  9:15     ` Andrew Morton
2008-03-04  3:09 ` [PATCH 07/14] isdn: " Harvey Harrison
2008-03-04  3:09 ` [PATCH 08/14] scsi: " Harvey Harrison
2008-03-04  3:30   ` James Bottomley [this message]
2008-03-04  3:44     ` Harvey Harrison
2008-03-04  3:09 ` [PATCH 09/14] ide: " Harvey Harrison
2008-03-04 21:25   ` Bartlomiej Zolnierkiewicz
2008-03-04  3:09 ` [PATCH 10/14] serial: " Harvey Harrison
2008-03-04  3:09 ` [PATCH 11/14] drivers/parisc: " Harvey Harrison
2008-03-04  3:09 ` [PATCH 12/14] video: " Harvey Harrison
2008-03-04  3:09 ` [PATCH 13/14] rtc: " Harvey Harrison
2008-03-04  3:09 ` [PATCH 14/14] fusion: " Harvey Harrison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1204601400.3043.102.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=harvey.harrison@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox