The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: git bisect in 2.6.25-rc1 looks weird
Date: Fri, 07 Mar 2008 15:50:17 +0800	[thread overview]
Message-ID: <1204876217.17994.50.camel@ymzhang> (raw)
In-Reply-To: <20080307073434.GA27975@elte.hu>

On Fri, 2008-03-07 at 08:34 +0100, Ingo Molnar wrote:
> * Zhang, Yanmin <yanmin_zhang@linux.intel.com> wrote:
> 
> > Are the patches committed in line? or there are many paths crossing?
> 
> it's fine. git-bisect works on a tree of commits (not a queue/line of 
> commits) - so certain 'lines' of patches can jump in and out.
> 
> the scheduler patches are always in a straight line, so later on in the 
> bisection the jumping should be simplified.
Thanks.

> 
> you might want to look at "gitk" output and pick out a specific line of 
> scheduler patches. For example:
> 
>   commit 32a76006683f7b28ae3cc491da37716e002f198e
> 
> to:
> 
>   commit 6d082592b62689fb91578d0338d04a9f50991990
> 
> is a straight line of 95 scheduler related commits. That's one of the 
> probable areas where the regression you are looking for came in. 
> 
> when you bisect that specific range, you should try to undo the 
> following two commits:
It looks like many patches commited ater the 2 patches changed same
code lines or nearby code lines. So there are many conflictions when I undo
the 2 patches.

Let me retry.

> 
>       commit 58e2d4ca581167c2a079f4ee02be2f0bc52e8729
>       Author: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
>       Date:   Fri Jan 25 21:08:00 2008 +0100
>       sched: group scheduling, change how cpu load is calculated
> 
>       commit 6b2d7700266b9402e12824e11e0099ae6a4a6a79
>       Author: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
>       Date:   Fri Jan 25 21:08:00 2008 +0100
>       sched: group scheduler, fix fairness of cpu bandwidth allocation for task
> 
> 	Ingo


      reply	other threads:[~2008-03-07  7:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-07  6:42 git bisect in 2.6.25-rc1 looks weird Zhang, Yanmin
2008-03-07  7:34 ` Ingo Molnar
2008-03-07  7:50   ` Zhang, Yanmin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1204876217.17994.50.camel@ymzhang \
    --to=yanmin_zhang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox