Re: ADT746X: logical-bitwise & confusion in set_max_duty_at_crit()

Segher Boessenkool
2008-03-10T21:57:20Z

> It includes suggested changes by Segher Boessenkool and I think this
> version was tested by Darrick J. Wong

> - u8 reg;
> + u8 reg, temp;
> struct i2c_client *client = to_i2c_client(dev);
> struct adt7473_data *data = i2c_get_clientdata(client);
> - int temp = simple_strtol(buf, NULL, 10);
> - temp = temp && 0xFF;
> +
> + temp = simple_strtol(buf, NULL, 10) & 0xFF;

It still does this superfluous "& 0xff", which hides the lack of
range checking.

Segher