Re: Regression: Re: [patch -mm 2/4] mempolicy: create mempolicy_operations structure

David Rientjes
2008-03-07T21:49:37Z

On Fri, 7 Mar 2008, Lee Schermerhorn wrote:

> It also appears that the patch series listed above required a non-empty
> nodemask with MPOL_DEFAULT. However, I didn't test that. With this
> patch, MPOL_DEFAULT effectively ignores the nodemask--empty or not.
> This is a change in behavior that I have argued against, but the
> regression tests don't test this, so I'm not going to attempt to address
> it with this patch.
>

Excuse me, but there was significant discussion about this on LKML and I
eventually did force MPOL_DEFAULT to require a non-empty nodemask
specifically because of your demand that it should. It didn't originally
require this in my patchset, and now you're removing the exact same
requirement that you demanded.

You said on February 13:

1) we've discussed the issue of returning EINVAL for non-empty
nodemasks with MPOL_DEFAULT. By removing this restriction, we run
the risk of breaking applications if we should ever want to define
a semantic to non-empty node mask for MPOL_DEFAULT.

If you want to remove this requirement now (please get agreement from
Paul) and are sure of your position, you'll at least need an update to
Documentation/vm/numa-memory-policy.txt.