From: Joe Perches <joe@perches.com>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: Roel Kluin <12o3l@tiscali.nl>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/net/wan/wanxl.c: time_before(timeout, jiffies) -> jiffies, timeout
Date: Mon, 24 Mar 2008 08:52:21 -0700 [thread overview]
Message-ID: <1206373941.4845.21.camel@localhost> (raw)
In-Reply-To: <m3fxug2mk3.fsf@maximus.localdomain>
On Mon, 2008-03-24 at 16:01 +0100, Krzysztof Halasa wrote:
> Joe Perches <joe@perches.com> writes:
> > Wouldn't it be better to have a schedule() in those
> > while loops too?
> There is a schedule() here:
What's the value of not having schedule() in the
wanxl_open and wanxl_close routines?
next prev parent reply other threads:[~2008-03-24 15:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 15:43 [PATCH] drivers/net/wan/wanxl.c: time_before(timeout, jiffies) -> jiffies, timeout Roel Kluin
2008-03-20 16:46 ` Joe Perches
2008-03-20 20:23 ` Roel Kluin
2008-03-20 21:06 ` Joe Perches
2008-03-24 15:01 ` Krzysztof Halasa
2008-03-24 15:52 ` Joe Perches [this message]
2008-03-24 20:22 ` Krzysztof Halasa
2008-03-24 14:42 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206373941.4845.21.camel@localhost \
--to=joe@perches.com \
--cc=12o3l@tiscali.nl \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).