From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Gary Hade <garyhade@us.ibm.com>, Ingo Molnar <mingo@elte.hu>,
Thomas Meyer <thomas@m3y3r.de>,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
Thomas Gleixner <tglx@linutronix.de>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
LKML <linux-kernel@vger.kernel.org>,
Adrian Bunk <bunk@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Natalie Protasevich <protasnb@gmail.com>,
pm@debian.org
Subject: Re: [patch] pci: revert "PCI: remove transparent bridge sizing"
Date: Thu, 27 Mar 2008 08:57:55 +1100 [thread overview]
Message-ID: <1206568675.6926.7.camel@pasglop> (raw)
In-Reply-To: <alpine.LFD.1.00.0803261416390.2775@woody.linux-foundation.org>
> NOTE! This will also consider a bridge resource at 0 to be an invalid
> resource (since now the alignment will be zero), which is a bit odd and
> makes me worry a bit. I wouldn't be surprised if some non-PC architectures
> have PCI bridges at zero. But maybe they should be (or already are?)
> marked IORESOURCE_PCI_FIXED?
PCI bridges at zero is perfectly valid indeed and I'm sure we have that
around at least for IO space. In fact, I'm surprised you don't have that
on x86. Typically, things like an HT segment with a P2P bridge and
behind that bridge an ISA bridge could well have the P2P bridge with a
resource forwarding 0...0x1000 IO downstream for example even on x86
no ? (I'm not -that- familiar with the crazyness of legacy ISA on x86
but I've definitely seen such setup on other archs).
For MMIO, it mostly depends whether the code gets to work on raw bus
values, in which case 0 will be around, or already fixed up values (ie,
translated in CPU bus space) in which case 0 is unlikely.
In the case of pdev_sort_resources(), it will manipulate already fixed
up resources, so MMIO should work, but I'm a bit worried by PIO.
Ben.
next prev parent reply other threads:[~2008-03-26 22:00 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-22 1:59 2.6.25-rc6-git6: Reported regressions from 2.6.24 Rafael J. Wysocki
2008-03-22 2:52 ` Jeff Garzik
2008-03-22 11:11 ` Ingo Molnar
2008-03-22 5:33 ` Andrew Morton
2008-03-22 11:15 ` Ingo Molnar
2008-03-22 17:53 ` Rafael J. Wysocki
2008-03-22 16:32 ` Heiko Carstens
2008-03-22 17:56 ` Rafael J. Wysocki
2008-03-22 16:34 ` ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Reported regressions from 2.6.24) Stefan Richter
2008-03-22 17:24 ` Thomas Meyer
2008-03-22 17:58 ` Rafael J. Wysocki
2008-03-22 18:27 ` Stefan Richter
2008-03-22 19:02 ` Stefan Richter
2008-03-22 21:33 ` Linus Torvalds
2008-03-22 21:58 ` Thomas Gleixner
2008-03-22 21:59 ` H. Peter Anvin
2008-03-22 22:27 ` ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Reported regressions from 2.6.24) [Bug 10080] Stefan Richter
2008-03-22 23:28 ` ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Reported regressions from 2.6.24) Yinghai Lu
2008-03-22 23:31 ` H. Peter Anvin
2008-03-23 2:00 ` Yinghai Lu
2008-03-23 2:39 ` H. Peter Anvin
2008-03-23 3:30 ` Yinghai Lu
2008-03-22 23:01 ` Linus Torvalds
2008-03-22 23:50 ` Stefan Richter
2008-03-23 6:35 ` Ingo Molnar
2008-03-24 19:34 ` Thomas Meyer
2008-03-24 19:47 ` Ingo Molnar
2008-03-24 20:17 ` Thomas Meyer
2008-03-24 20:47 ` Linus Torvalds
2008-03-26 3:39 ` Benjamin Herrenschmidt
2008-03-26 23:25 ` Benjamin Herrenschmidt
2008-03-24 19:58 ` Thomas Meyer
2008-03-24 20:50 ` Linus Torvalds
2008-03-24 21:24 ` Stefan Richter
2008-03-24 21:47 ` Stefan Richter
2008-03-25 7:31 ` Ingo Molnar
2008-03-25 16:50 ` Ingo Molnar
2008-03-25 17:06 ` Stefan Richter
2008-03-25 18:32 ` Thomas Meyer
2008-03-25 20:11 ` Ingo Molnar
2008-03-25 20:29 ` Ingo Molnar
2008-03-25 21:08 ` Thomas Meyer
2008-03-25 21:47 ` Linus Torvalds
2008-03-25 22:02 ` Thomas Meyer
2008-03-26 10:14 ` Ivan Kokshaysky
2008-03-26 12:17 ` Benjamin Herrenschmidt
2008-03-26 13:54 ` [patch] pci: revert "PCI: remove transparent bridge sizing" Ingo Molnar
2008-03-26 17:45 ` Thomas Meyer
2008-03-26 18:07 ` Gary Hade
2008-03-26 18:33 ` Linus Torvalds
2008-03-26 20:30 ` Gary Hade
2008-03-26 20:46 ` Linus Torvalds
2008-03-26 20:58 ` Ivan Kokshaysky
2008-03-26 21:41 ` Linus Torvalds
2008-03-26 21:57 ` Benjamin Herrenschmidt [this message]
2008-03-26 22:07 ` Alan Cox
2008-03-26 22:27 ` Benjamin Herrenschmidt
2008-03-26 22:10 ` Ingo Molnar
2008-03-26 22:29 ` Benjamin Herrenschmidt
2008-03-26 22:47 ` Linus Torvalds
2008-03-26 22:54 ` Benjamin Herrenschmidt
2008-03-26 23:18 ` Benjamin Herrenschmidt
2008-03-26 22:30 ` Ingo Molnar
2008-03-26 22:31 ` Linus Torvalds
2008-03-26 22:47 ` Alan Cox
2008-03-26 23:17 ` Benjamin Herrenschmidt
2008-03-26 23:29 ` Ivan Kokshaysky
2008-03-26 23:43 ` Linus Torvalds
2008-03-27 17:12 ` Linus Torvalds
2008-03-27 22:18 ` Ivan Kokshaysky
2008-03-27 22:34 ` Linus Torvalds
2008-03-28 19:24 ` Gary Hade
2008-03-28 20:46 ` Gary Hade
2008-03-30 15:44 ` Ivan Kokshaysky
2008-03-26 23:45 ` Benjamin Herrenschmidt
2008-03-26 21:29 ` Ingo Molnar
2008-03-26 11:12 ` ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Reported regressions from 2.6.24) Ivan Kokshaysky
2008-03-25 21:02 ` Thomas Meyer
2008-03-25 23:33 ` Benjamin Herrenschmidt
2008-03-26 0:03 ` Yinghai Lu
2008-03-26 0:12 ` Benjamin Herrenschmidt
2008-03-23 12:57 ` 2.6.25-rc6-git6: Reported regressions from 2.6.24 Alan Cox
2008-03-26 16:30 ` Ray Lee
2008-03-26 17:02 ` Adrian Bunk
2008-03-26 22:11 ` Rafael J. Wysocki
2008-03-27 10:18 ` Romano Giannetti
2008-03-27 14:43 ` Ray Lee
2008-03-31 18:21 ` Linus Torvalds
2008-03-31 19:29 ` Mark Lord
2008-03-31 21:04 ` Tino Keitel
2008-03-31 21:26 ` Tino Keitel
2008-04-03 19:06 ` 2.6.25-rc7/8: Another resume regression Mark Lord
2008-04-05 2:27 ` Mark Lord
2008-04-07 10:51 ` Rafael J. Wysocki
2008-04-07 15:51 ` Mark Lord
2008-04-07 17:40 ` Rafael J. Wysocki
2008-04-08 15:35 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206568675.6926.7.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=garyhade@us.ibm.com \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pm@debian.org \
--cc=protasnb@gmail.com \
--cc=rjw@sisk.pl \
--cc=stefanr@s5r6.in-berlin.de \
--cc=tglx@linutronix.de \
--cc=thomas@m3y3r.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).