From: "Pali Rohár" <pali.rohar@gmail.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: Anton Vorontsov <cbouatmailru@gmail.com>,
linux-kernel@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH] bq27x00_battery: fix flag register read
Date: Thu, 19 Jan 2012 02:49:03 -0800 (PST) [thread overview]
Message-ID: <12065816.FDViioMQvj@pali> (raw)
In-Reply-To: <1326574249-31334-1-git-send-email-notasas@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1487 bytes --]
On Saturday 14 January 2012 22:50:49 Grazvydas Ignotas wrote:
> When reading flags, bq27x00_read() argument is inverted and causes
> reads 2 of bytes for bq27200 and 1 byte for bq27500, while their register
> sizes are 1 and 2 bytes respectively. This causes bq27500 upper flag
> bits always to be returned as 0, causing full charge state to never be
> reported correctly, so fix it.
>
> Cc: Pali Rohár <pali.rohar@gmail.com>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
> ---
> drivers/power/bq27x00_battery.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/power/bq27x00_battery.c
> b/drivers/power/bq27x00_battery.c index 98bf567..86decb4 100644
> --- a/drivers/power/bq27x00_battery.c
> +++ b/drivers/power/bq27x00_battery.c
> @@ -312,7 +312,7 @@ static void bq27x00_update(struct bq27x00_device_info
> *di) struct bq27x00_reg_cache cache = {0, };
> bool is_bq27500 = di->chip == BQ27500;
>
> - cache.flags = bq27x00_read(di, BQ27x00_REG_FLAGS, is_bq27500);
> + cache.flags = bq27x00_read(di, BQ27x00_REG_FLAGS, !is_bq27500);
> if (cache.flags >= 0) {
> if (!is_bq27500 && (cache.flags & BQ27000_FLAG_CI)) {
> dev_info(di->dev, "battery is not calibrated! ignoring capacity
> values\n");
Yes, you are right, this patch fixing flags register reading.
Anton Vorontsov, can you send this patch to linux 3.3?
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-01-19 10:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-14 20:50 [PATCH] bq27x00_battery: fix flag register read Grazvydas Ignotas
2012-01-19 10:49 ` Pali Rohár [this message]
2012-02-01 17:36 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12065816.FDViioMQvj@pali \
--to=pali.rohar@gmail.com \
--cc=cbouatmailru@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).