Re: [PATCH 3/7] [NET]: uninline dev_alloc_skb, de-bloats a lot

Denys Vlasenko
2008-03-28T22:36:22Z

[-- Attachment #1: Type: text/plain, Size: 695 bytes --]

On Friday 28 March 2008 01:52, David Miller wrote:
> From: Denys Vlasenko <vda.linux@googlemail.com>
> Date: Fri, 28 Mar 2008 00:36:59 +0100
>
> > Can you add a comment which explains the intent?
> >
> > +struct sk_buff *dev_alloc_skb(unsigned int length)
> > +{
> > + /* There is more code here than it seems:
> > + * __dev_alloc_skb is an inline */
> > + return __dev_alloc_skb(length, GFP_ATOMIC);
> > +}
> > +EXPORT_SYMBOL(dev_alloc_skb);
>
> I've applied his patch already, if you want this comment
> please submit the patch to add it and also please use
> the correct formatting of the comment.

Here it is.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
--
vda

[-- Attachment #2: dev_alloc_skb_comment.diff --]
[-- Type: text/x-diff, Size: 374 bytes --]

--- net-2.6.26/net/core/skbuff.c Fri Mar 28 23:31:05 2008
+++ net-2.6.26.comment/net/core/skbuff.c Fri Mar 28 23:33:03 2008
@@ -277,6 +277,10 @@
*/
struct sk_buff *dev_alloc_skb(unsigned int length)
{
+ /*
+ * There is more code here than it seems:
+ * __def_alloc_skb is an inline
+ */
return __dev_alloc_skb(length, GFP_ATOMIC);
}
EXPORT_SYMBOL(dev_alloc_skb);