From: Gerald Schaefer <gerald.schaefer@de.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
haveblue@us.ibm.com, schwidefsky@de.ibm.com,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Tony Luck <tony.luck@intel.com>,
Paul Mackerras <paulus@samba.org>,
Thomas Gleixner <tglx@linutronix.de>,
Paul Mundt <lethal@linux-sh.org>
Subject: Re: [patch 09/10] Hugetlb common code update for System z.
Date: Fri, 28 Mar 2008 15:33:28 +0100 [thread overview]
Message-ID: <1206714808.5186.68.camel@localhost.localdomain> (raw)
In-Reply-To: <20080328140634.GA29218@elte.hu>
On Fri, 2008-03-28 at 15:06 +0100, Ingo Molnar wrote:
> * Gerald Schaefer <gerald.schaefer@de.ibm.com> wrote:
>
> > include/asm-sh/hugetlb.h | 28 +++++++++++++++++++++++++
> > include/asm-sparc64/hugetlb.h | 30 +++++++++++++++++++++++++++
> > include/asm-x86/hugetlb.h | 28 +++++++++++++++++++++++++
>
> these seem largely duplicated - shouldnt there be an
> asm-generic/hugetlb.h instead, which asm/hugetlb.h could include to get
> default behavior? It would probably reduce the linecount of your patch
> as well.
Right, asm-generic was also suggested by Andrew as a first step, before
getting rid of the ARCH_HAS_xxx stuff, and it would also reduce the loc.
But it would make things complicated if one architecture later wants to
take out some of the generic stuff to define it on their own, then they'd
need to touch all architecture headers again.
So I thought I'd rather not introduce the asm-generic header at all but
let all architectures have their own headers, risking code duplication
but hopefully making future updates easier.
--
Gerald Schaefer
next prev parent reply other threads:[~2008-03-28 14:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 17:31 [patch 00/10] System z10 patches Martin Schwidefsky
2008-03-12 17:31 ` [patch 01/10] Add new fields for System z10 to /proc/sysinfo Martin Schwidefsky
2008-03-12 17:57 ` Josef 'Jeff' Sipek
2008-03-13 10:02 ` Martin Schwidefsky
2008-03-12 17:31 ` [patch 02/10] Export stfle Martin Schwidefsky
2008-03-12 17:31 ` [patch 03/10] sched: add exported arch_reinit_sched_domains() to header file Martin Schwidefsky
2008-03-12 23:03 ` Andrew Morton
2008-03-13 9:48 ` Martin Schwidefsky
2008-03-21 12:29 ` Ingo Molnar
2008-03-12 17:31 ` [patch 04/10] sched: Add arch_update_cpu_topology hook Martin Schwidefsky
2008-03-21 12:30 ` Ingo Molnar
2008-03-12 17:32 ` [patch 05/10] cpu topology: convert siblings_show macro to accept non-lvalues Martin Schwidefsky
2008-03-12 17:32 ` [patch 06/10] cpu topology support for s390 Martin Schwidefsky
2008-03-12 23:11 ` Andrew Morton
2008-03-13 12:28 ` Martin Schwidefsky
2008-03-13 22:40 ` Heiko Carstens
2008-03-12 17:32 ` [patch 07/10] Vertical cpu management Martin Schwidefsky
2008-03-12 17:32 ` [patch 08/10] Add missing TLB flush to hugetlb_cow() Martin Schwidefsky
2008-03-12 17:32 ` [patch 09/10] Hugetlb common code update for System z Martin Schwidefsky
2008-03-12 17:51 ` Dave Hansen
2008-03-12 23:18 ` Gerald Schaefer
2008-03-12 23:43 ` Andrew Morton
2008-03-13 17:49 ` Gerald Schaefer
2008-03-28 14:05 ` Gerald Schaefer
2008-03-28 14:06 ` Ingo Molnar
2008-03-28 14:33 ` Gerald Schaefer [this message]
2008-03-28 15:53 ` Martin Schwidefsky
2008-03-28 16:03 ` Ingo Molnar
2008-03-12 17:32 ` [patch 10/10] System z large page support Martin Schwidefsky
2008-03-12 17:52 ` Dave Hansen
2008-03-12 22:14 ` Gerald Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206714808.5186.68.camel@localhost.localdomain \
--to=gerald.schaefer@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=haveblue@us.ibm.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox