Re: [patch 10/10] System z large page support.

Gerald Schaefer
2008-03-12T22:13:19Z

On Wed, 2008-03-12 at 10:52 -0700, Dave Hansen wrote:
> >
> > +pte_t *huge_pte_alloc(struct mm_struct *mm, unsigned long addr)
> > +{
> > + pgd_t *pgdp;
> > + pud_t *pudp;
> > + pmd_t *pmdp = NULL;
> > +
> > + pgdp = pgd_offset(mm, addr);
> > + pudp = pud_alloc(mm, pgdp, addr);
> > + if (pudp)
> > + pmdp = pmd_alloc(mm, pudp, addr);
> > + return (pte_t *) pmdp;
> > +}
>
> That looks pretty generic. Why can't you share with the version we
> already have?

What version do you mean? Every architecture with hugetlbfs support has
its own huge_pte_alloc() function in arch/<arch>/mm/hugetlbfs.c, and
they are all doing slightly different things.

--
Gerald Schaefer