Re: [patch 01/10] Add new fields for System z10 to /proc/sysinfo

Josef 'Jeff' Sipek
2008-03-12T17:58:19Z

On Wed, Mar 12, 2008 at 06:31:56PM +0100, Martin Schwidefsky wrote:
> From: Martin Schwidefsky <schwidefsky@de.ibm.com>
>
> Add permanent and temporary model capacity and the corresponding
> capacity value fields for the three capacity identifiers to the
> output of /proc/sysinfo.
>
> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
> ---
>
> drivers/s390/sysinfo.c | 21 +++++++++++++++++++--
> 1 file changed, 19 insertions(+), 2 deletions(-)
>
> Index: quilt-2.6/drivers/s390/sysinfo.c
> ===================================================================
> --- quilt-2.6.orig/drivers/s390/sysinfo.c
> +++ quilt-2.6/drivers/s390/sysinfo.c
> @@ -26,6 +26,11 @@ struct sysinfo_1_1_1 {
> char sequence[16];
> char plant[4];
> char model[16];
> + char model_perm_cap[16];
> + char model_temp_cap[16];
> + char model_cap_rating[4];
> + char model_perm_cap_rating[4];
> + char model_temp_cap_rating[4];
> };

I'd try to be safer, and make the struct __attribute__((packed))...

Josef 'Jeff' Sipek.

--
I'm somewhere between geek and normal.
- Linus Torvalds