Re: [patch 09/10] Hugetlb common code update for System z.

Gerald Schaefer
2008-03-28T14:31:51Z

On Fri, 2008-03-28 at 15:06 +0100, Ingo Molnar wrote:
> * Gerald Schaefer <gerald.schaefer@de.ibm.com> wrote:
>
> > include/asm-sh/hugetlb.h | 28 +++++++++++++++++++++++++
> > include/asm-sparc64/hugetlb.h | 30 +++++++++++++++++++++++++++
> > include/asm-x86/hugetlb.h | 28 +++++++++++++++++++++++++
>
> these seem largely duplicated - shouldnt there be an
> asm-generic/hugetlb.h instead, which asm/hugetlb.h could include to get
> default behavior? It would probably reduce the linecount of your patch
> as well.

Right, asm-generic was also suggested by Andrew as a first step, before
getting rid of the ARCH_HAS_xxx stuff, and it would also reduce the loc.
But it would make things complicated if one architecture later wants to
take out some of the generic stuff to define it on their own, then they'd
need to touch all architecture headers again.

So I thought I'd rather not introduce the asm-generic header at all but
let all architectures have their own headers, risking code duplication
but hopefully making future updates easier.

--
Gerald Schaefer