From: Harvey Harrison <harvey.harrison@gmail.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] asm-generic: suppress sparse warning in ioctl.h
Date: Mon, 31 Mar 2008 15:26:39 -0700 [thread overview]
Message-ID: <1207002399.6543.83.camel@brick> (raw)
In-Reply-To: <20080331215835.GM9785@ZenIV.linux.org.uk>
1 ? 0 : x
is not valid in contexts where C requires integer constant expressions.
Index in static array initializer is one of those.
Instead of using a non-existant extern function, use 1/0 as the guard
expression to avoid using a gcc-ism. IOC_TYPECHECK gets pulled into
some static array initializations where this is not valid.
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
I've confirmed this patch 'fixes' the large blocks of sparse warnings in
static array initializers.
include/asm-generic/ioctl.h | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/include/asm-generic/ioctl.h b/include/asm-generic/ioctl.h
index cd02729..f5ae529 100644
--- a/include/asm-generic/ioctl.h
+++ b/include/asm-generic/ioctl.h
@@ -47,12 +47,10 @@
((nr) << _IOC_NRSHIFT) | \
((size) << _IOC_SIZESHIFT))
-/* provoke compile error for invalid uses of size argument */
-extern unsigned int __invalid_size_argument_for_IOC;
#define _IOC_TYPECHECK(t) \
((sizeof(t) == sizeof(t[1]) && \
sizeof(t) < (1 << _IOC_SIZEBITS)) ? \
- sizeof(t) : __invalid_size_argument_for_IOC)
+ sizeof(t) : 1/0)
/* used to create numbers */
#define _IO(type,nr) _IOC(_IOC_NONE,(type),(nr),0)
--
1.5.5.rc1.135.g8527
prev parent reply other threads:[~2008-03-31 22:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1206998108.6543.74.camel@brick>
[not found] ` <1206999598.6543.76.camel@brick>
2008-03-31 21:58 ` Sparse Question Al Viro
2008-03-31 22:07 ` Harvey Harrison
2008-03-31 22:16 ` Harvey Harrison
2008-03-31 22:26 ` Harvey Harrison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207002399.6543.83.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox