From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760618AbYDAWcH (ORCPT ); Tue, 1 Apr 2008 18:32:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758127AbYDAWby (ORCPT ); Tue, 1 Apr 2008 18:31:54 -0400 Received: from mail.crca.org.au ([67.207.131.56]:39800 "EHLO crca.org.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754945AbYDAWbx (ORCPT ); Tue, 1 Apr 2008 18:31:53 -0400 X-Bogosity: Ham, spamicity=0.000000 Subject: Re: [RFC][PATCH] PM: Introduce new top level suspend and hibernation callbacks (rev. 6) From: Nigel Cunningham To: "Rafael J. Wysocki" Cc: pm list , ACPI Devel Maling List , Alan Stern , Greg KH , Len Brown , LKML , Alexey Starikovskiy , David Brownell , Pavel Machek , Benjamin Herrenschmidt , Oliver Neukum In-Reply-To: <200804012357.30529.rjw@sisk.pl> References: <200803292317.50218.rjw@sisk.pl> <200804012212.48609.rjw@sisk.pl> <1207085713.23143.111.camel@nigel-laptop> <200804012357.30529.rjw@sisk.pl> Content-Type: text/plain Organization: Christian Reformed Churches of Australia Date: Wed, 02 Apr 2008 09:32:18 +1100 Message-Id: <1207089138.23143.117.camel@nigel-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.22.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi. On Tue, 2008-04-01 at 23:57 +0200, Rafael J. Wysocki wrote: > On Tuesday, 1 of April 2008, Nigel Cunningham wrote: > > Hi Rafael etc. > > > > On Tue, 2008-04-01 at 22:12 +0200, Rafael J. Wysocki wrote: > > > 'ext' means 'extended'. The idea is that the 'extended' version will be used > > > by bus types / driver types that don't need to implement the _noirq callbacks. > > > Both the platform and PCI bus types generally allow drivers to use _noirq > > > callbacks, so they use 'struct pm_ext_ops', as well as their corresponding > > > driver types. > > > > Do you mean to say in the first sentence "...that _do_ need to implement..."? > > Yes, sorry. Okay. Thanks! > > If not, then extended sounds like a misnomer and the two > > sentences seem to contradict one another. > > > > [...] > > > > > > > + * However, drivers may NOT assume anything about the availability of the > > > > > + * user space at that time and it is not correct to request firmware from > > > > > + * within @prepare() (it's too late to do that). > > > > > > > > That doesn't sound good. It would be good to be able to get drivers to > > > > request firmware early in the process. > > > > > > That will be possible when we drop the freezer. > > > > Yeah, but right now, it seems to me to be a bogus limitation for drivers > > to have no way of automatically loading firmware when you're about to > > hibernate. (Of course I've since been reminded of the notifier chain - > > that should probably be mentioned here as the way of achieving this). > > This is a tricky stuff, though, because the notifier is used for disabling the > user mode helpers too ... Hmm. Yet another notifier? > > By the way, I'm going to go on record now as saying I think dropping the > > freezer is a silly idea. I'm therefore currently considering including > > the freezer in TuxOnice from the time it gets dropped from mainline. I > > know that will only make it less likely that TuxOnIce gets merged, but > > I've given up caring about that anyway - caring about merging is > > pointless when the people who decide if it gets merged don't care. > > Well, I'm just not sure if dropping the freezer entirely will actually work, > but we won't know that if we don't try. > > There's been a lot of pressure on going into this direction recently and > in principle it seems to be doable at least for suspend. Hibernation is > another issue, but IMO it's better to focus on suspend first. For suspend, I agree with dropping its use. For hibernation... Nigel